Update Customer.io destination with new mapping #2111
Conversation
| @@ -13,7 +13,7 @@ const action: ActionDefinition<Settings, Payload> = { | |||
| description: 'An object ID used to identify an object.', | |||
| type: 'string', | |||
| default: { | |||
| '@path': '$.context.groupId' | |||
| '@path': '$.groupId' | |||
There was a problem hiding this comment.
Hi @sydneycollins-cio - would it not make sense to do this following?
| '@path': '$.groupId' | |
| '@path': '$.properties.objectId' |
There was a problem hiding this comment.
This does make sense, I have updated this
| delete (custom_attributes as { traits?: { object_type_id?: unknown } })?.traits?.object_type_id | ||
| delete (custom_attributes as { traits?: { relationshipAttributes?: unknown } })?.traits?.relationshipAttributes |
There was a problem hiding this comment.
hi @sydneycollins-cio - can you explain what's supposed to be happening here, and how it differs from these lines ?
delete custom_attributes?.object_type_id
delete custom_attributes?.relationshipAttributes
There was a problem hiding this comment.
The idea is to remove these values from the object regardless inside traits or on the custom_attributes as our api is not going to use these values
| delete (custom_attributes as { traits?: { object_type_id?: unknown } })?.traits?.object_type_id | ||
| delete (custom_attributes as { traits?: { relationshipAttributes?: unknown } })?.traits?.relationshipAttributes |
There was a problem hiding this comment.
hi @sydneycollins-cio can you explain what these lines are attempting to do please?
There was a problem hiding this comment.
The idea is to remove these values from the object regardless inside traits or on the custom_attributes as our api is not going to use these values
There was a problem hiding this comment.
Hi @sydneycollins-cio thanks for clarifying.
I'm not sure this is going to work, however the code shouldn't cause any issues so it is OK to deploy.
delete (custom_attributes as { traits?: { object_type_id?: unknown } })?.traits?.object_type_id
will attempt to delete this attribute:
custom_attributes.traits.object_type_id
However I can't see how custom_attributes will ever contain the traits object.
Either way, I'm ok to deploy this - you can amend / fix if it doesn't work as you need.
|
hi @sydneycollins-cio this PR has been deployed. Can you please confirm that you are happy with the change? |
It looks great! thanks so much 🙏🏽 |
Updates the Customer.io destination:
Updated destinations
createUpdateObjectdeleteDevicedeleteObjectdeleteRelationshipTesting
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.