Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snap v3 CAPI] Additional SnapV3 connector tweaks #1913

Merged
merged 7 commits into from
Mar 12, 2024
Merged

[Snap v3 CAPI] Additional SnapV3 connector tweaks #1913

merged 7 commits into from
Mar 12, 2024

Conversation

bordoley
Copy link
Contributor

@bordoley bordoley commented Mar 6, 2024 •
edited
Loading

  • Update logic for selecting the app or pixel id based upon the event_conversion_type
  • Trim leading/trailing whitespace from string values.
  • Ensure num_items is an integer value

Testing

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment

@bordoley bordoley changed the title Update logic for selecting the app or pixel id based upon the event_c… [Snap v3 conversions] Additional SnapV3 connector tweaks Mar 6, 2024
@bordoley bordoley changed the title [Snap v3 conversions] Additional SnapV3 connector tweaks [Snap v3 CAPI] Additional SnapV3 connector tweaks Mar 6, 2024
@joe-ayoub-segment joe-ayoub-segment self-assigned this Mar 7, 2024
@bordoley bordoley marked this pull request as ready for review March 7, 2024 15:15
@bordoley bordoley requested a review from a team as a code owner March 7, 2024 15:15
@bordoley bordoley requested a review from a team March 7, 2024 15:15
@joe-ayoub-segment
Copy link
Contributor

hi @bordoley just one minor comment to look at/clarify.

@joe-ayoub-segment joe-ayoub-segment merged commit aa80fd2 into segmentio:main Mar 12, 2024
9 of 10 checks passed
@joe-ayoub-segment
Copy link
Contributor

hi @bordoley PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-ayoub-segment joe-ayoub-segment joe-ayoub-segment requested changes

Assignees

@joe-ayoub-segment joe-ayoub-segment

Labels
mode:cloud partner-eng-review (cloud) Ready for Release team:external
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bordoley @joe-ayoub-segment