[MAIN] [STRATCONN] 3313 add page view field in setConfigurationFields #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AnkitSegment Nice Work , LGTM ! |
Innovative-GauravKochar
approved these changes
Mar 1, 2024
varadarajan-tw
approved these changes
Mar 1, 2024
| send_page_view: true | ||
| }) | ||
| }) | ||
| it('should update config if payload has send_page_view true', () => { |
There was a problem hiding this comment.
Shouldn't this scenario not update config? I assume send_page_view is true by default.
Suggested change
| it('should update config if payload has send_page_view true', () => { | |
| it('should not update config if payload has send_page_view true', () => { |
|
PR deployed earlier this week. |
harsh-joshi99
added a commit
that referenced
this pull request
Mar 8, 2024
commit b897052 Author: Harsh Joshi <harsh.joshi@segment.com> Date: Fri Mar 8 14:09:59 2024 +0530 Update error handling in get audience commit f708118 Author: joe-ayoub-segment <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Wed Mar 6 12:15:27 2024 +0000 Publish - @segment/action-destinations@3.251.0 commit 1c3e2b4 Author: joe-ayoub-segment <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Wed Mar 6 12:03:17 2024 +0000 fixing broken field for optimizely data platform commit f5e6e4f Author: joe-ayoub-segment <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Wed Mar 6 11:56:07 2024 +0000 fixing breaking field for optimizely data platform commit f540306 Author: Marín Alcaraz <marin.alcarazcordova@segment.com> Date: Tue Mar 5 15:40:11 2024 -0800 Publish - @segment/action-destinations@3.250.0 commit 6a35edd Author: Marín Alcaraz <marin.alcarazcordova@segment.com> Date: Tue Mar 5 15:36:29 2024 -0800 DV360 - Update Chamber Variable (#1912) commit ed54b6b Author: joe-ayoub-segment <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 13:33:54 2024 +0000 Publish - @segment/actions-shared@1.81.0 - @segment/browser-destination-runtime@1.30.0 - @segment/actions-core@3.100.0 - @segment/action-destinations@3.249.0 - @segment/destinations-manifest@1.43.0 - @segment/analytics-browser-actions-1flow@1.13.0 - @segment/analytics-browser-actions-adobe-target@1.31.0 - @segment/analytics-browser-actions-algolia-plugins@1.8.0 - @segment/analytics-browser-actions-amplitude-plugins@1.31.0 - @segment/analytics-browser-actions-braze-cloud-plugins@1.34.0 - @segment/analytics-browser-actions-braze@1.34.0 - @segment/analytics-browser-actions-bucket@1.11.0 - @segment/analytics-browser-actions-cdpresolution@1.18.0 - @segment/analytics-browser-actions-commandbar@1.31.0 - @segment/analytics-browser-actions-devrev@1.18.0 - @segment/analytics-browser-actions-friendbuy@1.31.0 - @segment/analytics-browser-actions-fullstory@1.33.0 - @segment/analytics-browser-actions-google-analytics-4@1.37.0 - @segment/analytics-browser-actions-google-campaign-manager@1.21.0 - @segment/analytics-browser-actions-heap@1.31.0 - @segment/analytics-browser-hubble-web@1.17.0 - @segment/analytics-browser-actions-hubspot@1.31.0 - @segment/analytics-browser-actions-intercom@1.31.0 - @segment/analytics-browser-actions-iterate@1.31.0 - @segment/analytics-browser-actions-jimo@1.19.0 - @segment/analytics-browser-actions-koala@1.31.0 - @segment/analytics-browser-actions-logrocket@1.31.0 - @segment/analytics-browser-actions-pendo-web-actions@1.20.0 - @segment/analytics-browser-actions-playerzero@1.31.0 - @segment/analytics-browser-actions-replaybird@1.12.0 - @segment/analytics-browser-actions-ripe@1.31.0 - @segment/analytics-browser-actions-rupt@1.20.0 - @segment/analytics-browser-actions-screeb@1.31.0 - @segment/analytics-browser-actions-utils@1.31.0 - @segment/analytics-browser-actions-snap-plugins@1.12.0 - @segment/analytics-browser-actions-sprig@1.31.0 - @segment/analytics-browser-actions-stackadapt@1.31.0 - @segment/analytics-browser-actions-survicate@1.7.0 - @segment/analytics-browser-actions-tiktok-pixel@1.28.0 - @segment/analytics-browser-actions-upollo@1.31.0 - @segment/analytics-browser-actions-userpilot@1.31.0 - @segment/analytics-browser-actions-vwo@1.32.0 - @segment/analytics-browser-actions-wiseops@1.31.0 commit 8793063 Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 13:30:12 2024 +0000 Registering kevel-audience commit 82a80b9 Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 13:19:12 2024 +0000 Optimizely data platform changes (#1906) * changes to ODP Destination * fixing tests * adding campaign_id to email action * fixing preset commit e0a5d6b Author: Dave <bordoley@gmail.com> Date: Tue Mar 5 08:13:34 2024 -0500 Snap misc fixes (#1900) * set the app_id to undefined if empty. Set advertiser_tracking_enabled to 0 if the app_id is defined * add comment on advertiser_tracking_enabled field usage * tweak app_data and extinfo build * update box function to return undefined if the input string is empty or undefined instead of an empty array * fix tests * fix typo * simplify action_source logic * update tests to validate advertiser_tracking_enabled and changes to box function * cleaner implementation of emptyStringtoUndefined * simpler implementation of box * remove duplicate util function * fix function name * log errors as critical * add prefix to logger entries --------- Co-authored-by: David Bordoley <dbordoley@snapchat.com> commit b8439ca Author: suppalapati <110847862+Sneha-Uppalapati@users.noreply.github.com> Date: Tue Mar 5 05:12:28 2024 -0800 Channels-1034 Set google Api version for Push (#1883) * feat: set googleApiVersion * fix: set legacy as default version * fix: defaults --------- Co-authored-by: suppalapati <sneha.uppalapati@segment.com> Co-authored-by: alfrimpong <afrimpong@twilio.com> commit a77f4a7 Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 13:11:18 2024 +0000 basic SSL config options (#1908) commit 726d281 Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 11:23:49 2024 +0000 Adding new kevel-audience Destination (#1910) * adding kevel-audience Destination * fixing spelling issue commit ca71fbf Author: mayur-pitale <109548891+mayur-pitale@users.noreply.github.com> Date: Tue Mar 5 01:54:20 2024 -0800 Added encoding to username & password (#1909) commit 529e786 Author: hvardhan-unth <117922634+hvardhan-unth@users.noreply.github.com> Date: Tue Mar 5 15:10:01 2024 +0530 [Stratconn 3257] Add batching to segment connections (#1859) * Added batching for all the actions of segment destination * Added the unit test cases for batching * Updated the test case for batch happy path * Updated the test case * Updated the tag name for batch matrix * Added enable batching field * Revert the unwanted changes and updated the perform block * Revert the unwanted changes * Revert the unwanted changes * Changes output text for batch execution --------- Co-authored-by: Harsh Vardhan <harsh.vardhan@segment.com> commit 53b4441 Author: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Date: Tue Mar 5 10:32:49 2024 +0530 [STRATCONN-3623] - Adds github actions workflow to label PRs (#1905) * Adds PR labeler workflow * rename token * update secret name * fix script path * change path * Delete scripts folder * dummy commit * update registration regex * Add comments on checks commit 8d3a139 Author: Ankit Gupta <139338151+AnkitSegment@users.noreply.github.com> Date: Mon Mar 4 23:39:15 2024 +0530 [MAIN] [STRATCONN] 3313 add page view field in setConfigurationFields (#1904) * send_page_view mapping added * updated unit test cases of send_page_view in setConfigurationFields * removed unrelevent code * removed unrelevent code
harsh-joshi99
added a commit
that referenced
this pull request
Mar 8, 2024
commit 473990d Author: Harsh Joshi <harsh.joshi@segment.com> Date: Fri Mar 8 14:49:37 2024 +0530 Add test case for error commit b897052 Author: Harsh Joshi <harsh.joshi@segment.com> Date: Fri Mar 8 14:09:59 2024 +0530 Update error handling in get audience commit f708118 Author: joe-ayoub-segment <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Wed Mar 6 12:15:27 2024 +0000 Publish - @segment/action-destinations@3.251.0 commit 1c3e2b4 Author: joe-ayoub-segment <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Wed Mar 6 12:03:17 2024 +0000 fixing broken field for optimizely data platform commit f5e6e4f Author: joe-ayoub-segment <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Wed Mar 6 11:56:07 2024 +0000 fixing breaking field for optimizely data platform commit f540306 Author: Marín Alcaraz <marin.alcarazcordova@segment.com> Date: Tue Mar 5 15:40:11 2024 -0800 Publish - @segment/action-destinations@3.250.0 commit 6a35edd Author: Marín Alcaraz <marin.alcarazcordova@segment.com> Date: Tue Mar 5 15:36:29 2024 -0800 DV360 - Update Chamber Variable (#1912) commit ed54b6b Author: joe-ayoub-segment <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 13:33:54 2024 +0000 Publish - @segment/actions-shared@1.81.0 - @segment/browser-destination-runtime@1.30.0 - @segment/actions-core@3.100.0 - @segment/action-destinations@3.249.0 - @segment/destinations-manifest@1.43.0 - @segment/analytics-browser-actions-1flow@1.13.0 - @segment/analytics-browser-actions-adobe-target@1.31.0 - @segment/analytics-browser-actions-algolia-plugins@1.8.0 - @segment/analytics-browser-actions-amplitude-plugins@1.31.0 - @segment/analytics-browser-actions-braze-cloud-plugins@1.34.0 - @segment/analytics-browser-actions-braze@1.34.0 - @segment/analytics-browser-actions-bucket@1.11.0 - @segment/analytics-browser-actions-cdpresolution@1.18.0 - @segment/analytics-browser-actions-commandbar@1.31.0 - @segment/analytics-browser-actions-devrev@1.18.0 - @segment/analytics-browser-actions-friendbuy@1.31.0 - @segment/analytics-browser-actions-fullstory@1.33.0 - @segment/analytics-browser-actions-google-analytics-4@1.37.0 - @segment/analytics-browser-actions-google-campaign-manager@1.21.0 - @segment/analytics-browser-actions-heap@1.31.0 - @segment/analytics-browser-hubble-web@1.17.0 - @segment/analytics-browser-actions-hubspot@1.31.0 - @segment/analytics-browser-actions-intercom@1.31.0 - @segment/analytics-browser-actions-iterate@1.31.0 - @segment/analytics-browser-actions-jimo@1.19.0 - @segment/analytics-browser-actions-koala@1.31.0 - @segment/analytics-browser-actions-logrocket@1.31.0 - @segment/analytics-browser-actions-pendo-web-actions@1.20.0 - @segment/analytics-browser-actions-playerzero@1.31.0 - @segment/analytics-browser-actions-replaybird@1.12.0 - @segment/analytics-browser-actions-ripe@1.31.0 - @segment/analytics-browser-actions-rupt@1.20.0 - @segment/analytics-browser-actions-screeb@1.31.0 - @segment/analytics-browser-actions-utils@1.31.0 - @segment/analytics-browser-actions-snap-plugins@1.12.0 - @segment/analytics-browser-actions-sprig@1.31.0 - @segment/analytics-browser-actions-stackadapt@1.31.0 - @segment/analytics-browser-actions-survicate@1.7.0 - @segment/analytics-browser-actions-tiktok-pixel@1.28.0 - @segment/analytics-browser-actions-upollo@1.31.0 - @segment/analytics-browser-actions-userpilot@1.31.0 - @segment/analytics-browser-actions-vwo@1.32.0 - @segment/analytics-browser-actions-wiseops@1.31.0 commit 8793063 Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 13:30:12 2024 +0000 Registering kevel-audience commit 82a80b9 Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 13:19:12 2024 +0000 Optimizely data platform changes (#1906) * changes to ODP Destination * fixing tests * adding campaign_id to email action * fixing preset commit e0a5d6b Author: Dave <bordoley@gmail.com> Date: Tue Mar 5 08:13:34 2024 -0500 Snap misc fixes (#1900) * set the app_id to undefined if empty. Set advertiser_tracking_enabled to 0 if the app_id is defined * add comment on advertiser_tracking_enabled field usage * tweak app_data and extinfo build * update box function to return undefined if the input string is empty or undefined instead of an empty array * fix tests * fix typo * simplify action_source logic * update tests to validate advertiser_tracking_enabled and changes to box function * cleaner implementation of emptyStringtoUndefined * simpler implementation of box * remove duplicate util function * fix function name * log errors as critical * add prefix to logger entries --------- Co-authored-by: David Bordoley <dbordoley@snapchat.com> commit b8439ca Author: suppalapati <110847862+Sneha-Uppalapati@users.noreply.github.com> Date: Tue Mar 5 05:12:28 2024 -0800 Channels-1034 Set google Api version for Push (#1883) * feat: set googleApiVersion * fix: set legacy as default version * fix: defaults --------- Co-authored-by: suppalapati <sneha.uppalapati@segment.com> Co-authored-by: alfrimpong <afrimpong@twilio.com> commit a77f4a7 Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 13:11:18 2024 +0000 basic SSL config options (#1908) commit 726d281 Author: Joe Ayoub <45374896+joe-ayoub-segment@users.noreply.github.com> Date: Tue Mar 5 11:23:49 2024 +0000 Adding new kevel-audience Destination (#1910) * adding kevel-audience Destination * fixing spelling issue commit ca71fbf Author: mayur-pitale <109548891+mayur-pitale@users.noreply.github.com> Date: Tue Mar 5 01:54:20 2024 -0800 Added encoding to username & password (#1909) commit 529e786 Author: hvardhan-unth <117922634+hvardhan-unth@users.noreply.github.com> Date: Tue Mar 5 15:10:01 2024 +0530 [Stratconn 3257] Add batching to segment connections (#1859) * Added batching for all the actions of segment destination * Added the unit test cases for batching * Updated the test case for batch happy path * Updated the test case * Updated the tag name for batch matrix * Added enable batching field * Revert the unwanted changes and updated the perform block * Revert the unwanted changes * Revert the unwanted changes * Changes output text for batch execution --------- Co-authored-by: Harsh Vardhan <harsh.vardhan@segment.com> commit 53b4441 Author: Varadarajan V <109586712+varadarajan-tw@users.noreply.github.com> Date: Tue Mar 5 10:32:49 2024 +0530 [STRATCONN-3623] - Adds github actions workflow to label PRs (#1905) * Adds PR labeler workflow * rename token * update secret name * fix script path * change path * Delete scripts folder * dummy commit * update registration regex * Add comments on checks commit 8d3a139 Author: Ankit Gupta <139338151+AnkitSegment@users.noreply.github.com> Date: Mon Mar 4 23:39:15 2024 +0530 [MAIN] [STRATCONN] 3313 add page view field in setConfigurationFields (#1904) * send_page_view mapping added * updated unit test cases of send_page_view in setConfigurationFields * removed unrelevent code * removed unrelevent code
morrismatts
reviewed
Mar 8, 2024
| @@ -170,6 +179,10 @@ const action: BrowserActionDefinition<Settings, Function, Payload> = { | |||
| if (settings.pageView != true) { | |||
| config.send_page_view = settings.pageView ?? true | |||
| } | |||
|
|
|||
| if (payload.send_page_view != true) { | |||
| config.send_page_view = payload.send_page_view ?? true | |||
There was a problem hiding this comment.
@AnkitSegment @joe-ayoub-segment Shouldn't this be falling back to the setting before defaulting to true?
config.send_page_view = payload.send_page_view ?? settings.pageView ?? true
In the case where payload.send_page_view is undefined and settings.pageView is false, the config should have send_page_view as false, right?
If I'm understanding correctly, this change broke our Segment <=> GA4 integration where we have settings.pageView set to false. It started sending page view events we were previously deliberately avoiding when this got published.
There was a problem hiding this comment.
Thanks @morrismatts - I don't work on this Integration but have forwarded on your comment to be looked into.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added New Send page view field in setConfigurationFields mapping, so that user can modify send_page_view when required.
Jira ticket:
https://segment.atlassian.net/browse/STRATCONN-3313
Test Screenshot
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.