Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Destination for Kevel Audience #1902

Closed
wants to merge 5 commits into from
Closed

Conversation

tiagoboldt
Copy link

This Pull Request introduces an integration with Kevel Audience, a second product from Kevel. To avoid confusion, the current Kevel plugin that integrates through Kevel UserDB, still in Beta, was moved to the kevel-userdb folder, and the documentation was clarified.

Testing

The app was tested locally with identify and track events to verify both properties and audiences are sent. Some unit tests briefly verify the implementation.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [Segmenters] Tested in the staging environment - not done, not quite sure how to do this.

@tiagoboldt tiagoboldt requested a review from a team as a code owner February 29, 2024 23:49
@tiagoboldt tiagoboldt requested a review from a team February 29, 2024 23:49
@tiagoboldt tiagoboldt changed the title Plugin for Kevel Audience Destination for Kevel Audience Mar 1, 2024
@joe-ayoub-segment
Copy link
Contributor

Hi @tiagoboldt thanks for raising this PR.

I think the proposed changes warrant a face to face meeting. Would you be able to schedule a call with me here please?
https://calendly.com/joe_ayoub/

Best regards,
Joe

@joe-ayoub-segment
Copy link
Contributor

Moved the PR to an internal PR so I could make some minor wording changes.
I also retained the original slug, baut kept the new name for the Kevel-DB Destination.

Here is the new PR.
#1910

I'll deploy the code as is, however I think it would be useful to add a 'testAuthenication' function to validate the settings. This function gets called after the user inputs and saves the Settings for the Integration. There's plenty of examples of how to do this in the codebase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants