Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jun15 main #1344

Merged
merged 22 commits into from
Jun 20, 2023
Merged

Jun15 main #1344

merged 22 commits into from
Jun 20, 2023

Conversation

KWLandry-acoustic
Copy link
Contributor

@KWLandry-acoustic KWLandry-acoustic commented Jun 19, 2023

Description from Partner (@KWLandry-acoustic )

...this should improve exception handling, especially concurrency limit errors with a retryable exception, also, fyi, got the change to Pura org. so no longer need the table pre-check, which should also improve speed as it eliminates that call, there should now be a single POST to update the table versus the two that were needed prior,

refactor/improve exception handling, remove table chk.,

@KWLandry-acoustic KWLandry-acoustic requested a review from a team as a code owner June 19, 2023 15:35
@KWLandry-acoustic KWLandry-acoustic requested a review from a team June 19, 2023 15:35
Copy link
Contributor

@joe-ayoub-segment joe-ayoub-segment left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Just need CI to pass.

Signed-off-by: kwlandry-acoustic <kip.landry@acoustic.com>
@joe-ayoub-segment joe-ayoub-segment merged commit b6e8b05 into segmentio:main Jun 20, 2023
@joe-ayoub-segment
Copy link
Contributor

Hi @KWLandry-acoustic this PR has been deployed!

@KWLandry-acoustic KWLandry-acoustic deleted the Jun15_main branch June 28, 2023 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants