Taboola device id fix (#2170)

* updating device id field * fix tests
segmentio · Jul 16, 2024 · dd7c41c · dd7c41c
1 parent 2009c64
commit dd7c41c
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 17 deletions.
diff --git a/...destination-actions/src/destinations/taboola-actions/syncAudience/__tests__/index.test.ts b/...destination-actions/src/destinations/taboola-actions/syncAudience/__tests__/index.test.ts
@@ -19,9 +19,7 @@ describe('Taboola.syncAudience', () => {
       event: 'Audience Entered',
       type: 'track',
       properties: {
-        ios: {
-          id: DEVICE_ID
-        }
+        ios_id: DEVICE_ID
       },
       context: {
         device: {
@@ -131,9 +129,7 @@ describe('Taboola.syncAudience', () => {
       event: 'Audience Entered',
       type: 'track',
       properties: {
-        ios: {
-          id: DEVICE_ID
-        }
+        ios_id: DEVICE_ID
       },
       context: {
         device: {
@@ -172,9 +168,7 @@ describe('Taboola.syncAudience', () => {
         event: 'Audience Entered',
         type: 'track',
         properties: {
-          ios: {
-            id: DEVICE_ID
-          }
+          ios_id: DEVICE_ID
         },
         context: {
           device: {
@@ -196,9 +190,7 @@ describe('Taboola.syncAudience', () => {
         event: 'Audience Exited',
         type: 'track',
         properties: {
-          ios: {
-            id: '456'
-          }
+          ios_id: '456'
         },
         context: {
           device: {

diff --git a/...ages/destination-actions/src/destinations/taboola-actions/syncAudience/generated-types.ts b/...ages/destination-actions/src/destinations/taboola-actions/syncAudience/generated-types.ts
diff --git a/packages/destination-actions/src/destinations/taboola-actions/syncAudience/index.ts b/packages/destination-actions/src/destinations/taboola-actions/syncAudience/index.ts
@@ -80,15 +80,15 @@ const action: ActionDefinition<Settings, Payload, AudienceSettings> = {
     device_id: {
       label: 'Mobile Device ID',
       description:
-        "To send iOS and Android Device IDs, include the 'ios.id' and 'android.id' Identifiers from the 'Customized Setup' option when connecting your Audience.",
+        "To send iOS and Android Device IDs include them as 'ios_id' and 'android_id' via the 'Customized Setup' option when connecting your Audience.",
       type: 'string',
       required: false,
       unsafe_hidden: false,
       default: {
         '@if': {
-          exists: { '@path': '$.properties.ios.id' },
-          then: { '@path': '$.properties.ios.id' },
-          else: { '@path': '$.properties.android.id' }
+          exists: { '@path': '$.properties.ios_id' },
+          then: { '@path': '$.properties.ios_id' },
+          else: { '@path': '$.properties.android_id' }
         }
       }
     },