Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce the newline-before-return rule #68

Merged
merged 1 commit into from
Jan 18, 2017
Merged

Enforce the newline-before-return rule #68

merged 1 commit into from
Jan 18, 2017

Conversation

filipefigcorreia
Copy link
Contributor

@filipefigcorreia filipefigcorreia commented Jan 17, 2017 •
edited
Loading

May this be an interesting rule for the linter to enforce? It is one that we are enforcing on code reviews.

@filipefigcorreia filipefigcorreia force-pushed the enhancement/newline-before-return branch 2 times, most recently from 2e561d1 to 03fd3ed Compare January 18, 2017 14:13
@filipefigcorreia filipefigcorreia force-pushed the enhancement/newline-before-return branch from 03fd3ed to 199ce48 Compare January 18, 2017 14:18
@filipefigcorreia
Copy link
Contributor Author

Ready for review

rplopes
rplopes approved these changes Jan 18, 2017
View reviewed changes
Copy link
Contributor

@rplopes rplopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this is something we were already enforcing, so it's great to have a rule doing that work for us. Thanks.

@rplopes rplopes merged commit a1e60ae into seegno:master Jan 18, 2017
@filipefigcorreia filipefigcorreia deleted the enhancement/newline-before-return branch January 18, 2017 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rplopes rplopes rplopes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@filipefigcorreia @rplopes