Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI for Windows #587

Merged
merged 61 commits into from
Jan 3, 2023
Merged

CI for Windows #587

merged 61 commits into from
Jan 3, 2023

Conversation

itrushkin
Copy link
Contributor

@itrushkin itrushkin commented Nov 14, 2022 •
edited
Loading

CI support for Windows

To adapt test code for Windows, it is recommended to use an OS-invariant tool. I would like to use Python files for it. Please comment if you have any concerns.

Replacing test bash scripts with Python files

Test Tested on Windows Tested on Ubuntu (20.04)
test_hello_federation ✔️ ✔️
dockerization_test ❌ Requires switching Docker to Linux Engine ✔️
test_double_ws_export ✔️ ✔️
test_fets_challenge ❌ (GANDLF lib issue) ✔️
test_graminize N/A ❌(see Graminize issue below)
  • Include Windows jobs in CI workflows

WIndows Issues found

  1. TaskRunner | Job link
    click tries to write to a file with cp-1252 encoding. Gets an error:
UnicodeEncodeError: 'charmap' codec can't encode characters in position 0-2: character maps to <undefined>

Fixed in #610.
2. Graminize |
fx workspace import fails with an error:

ERROR: No matching distribution found for openfl==1.4

@itrushkin
Rewrite 'Hello Federation' test
81ac721 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Isolate 'Hello Federation' test
c444c70 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Rewrite 'dockerization_test'
d705391 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Add copyright notice
7a65992 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Add FeTS challenge test
b620e62 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Move initialization of 'Hello federation' test in the main part
33489df 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Update FeTS Challenge workflow
89ae12d 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix FeTS challenge test
00aa072 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix FeTS challenge test
1608078 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Check col2 existence in hello federation test
1ea48c1 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Add pause
dad545e 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Specify worker number explicitly
8586a40 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Specify workers count
33f8c1b 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix errors
4159725 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Include Windows in workflows
eb3ce97 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix Kvasir interactive API test
3610cff 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix imports
e39772a 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix paths
c741901 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix import
cd03f0e 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Replace wget
bcb2dc2 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Replace wget & unzip
7874bb6 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Bump tensorflow version
d3a05a6 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Run linter and coverage tests on Ubuntu only
514950e 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Add comments
e2c0278 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Merge branch 'develop' into windows_ci
d9e5a47 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Include saving logic in Hello Federation script
c8bbebd 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix linter
3afa2ac 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Add Dockerization workflow
3e4827b 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Switch docker engine for Windows
9669f5b 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Remove Windows in dockerization test
518a348 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@psfoley psfoley requested review from mansishr and psfoley December 14, 2022 17:10
@itrushkin
Move tensorflow interactive API test to Python
20d0685 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Parametrize config files
e0ba628 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Remove config parameters
db168f9 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Add removing utility
55d6c5a 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Pin tensorflow to 2.8.3
b40bddf 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin itrushkin marked this pull request as ready for review December 15, 2022 22:51
@itrushkin
Remove Graminize test
7a6d0a2 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Update straggler handling test
f7469ab 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Remove Windows from Interactive TF test
7beb2d7 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Reuse common test logic
ecc0a1a 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix imports & calls
d53df24 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Use relative imports
51be78c 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Debug sys path
15b7f9f 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Execute module
90004e3 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Run Python modules
4f2df18 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Remove unused strategy matrix
d207db3 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Fix FeTS challenge test
82c6640 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
psfoley
psfoley approved these changes Dec 17, 2022
View reviewed changes
Copy link
Contributor

@psfoley psfoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done!

mansishr
mansishr approved these changes Dec 19, 2022
View reviewed changes
Copy link
Collaborator

@mansishr mansishr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, well done!

@itrushkin
Resolve review comments
096c2a0 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin
Remove debug code
55dba54 
Signed-off-by: Ilya Trushkin <ilya.trushkin@intel.com>
@itrushkin itrushkin mentioned this pull request Jan 3, 2023
Open
@psfoley psfoley merged commit 30e212f into develop Jan 3, 2023
@psfoley psfoley mentioned this pull request Jan 12, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psfoley psfoley psfoley approved these changes

@aleksandr-mokrov aleksandr-mokrov aleksandr-mokrov approved these changes

@mansishr mansishr mansishr approved these changes

@igor-davidyuk igor-davidyuk Awaiting requested review from igor-davidyuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@itrushkin @psfoley @aleksandr-mokrov @mansishr