-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Straggler handling Follow-up #1097
Straggler handling Follow-up #1097
Conversation
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
@ishant162 , did you test for regression by raising a PR in OpenFL-Security? |
This needs to be done @teoparvanov . We will feedback once it is done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good improvement over the previous layout.
Most suggestions, though seem like nitpicks, have measurable changes on developers and users in the look-and-feel of the framework. Please take a look.
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, thanks @ishant162 ! I just have a couple of minor comments:
docs/developer_guide/advanced_topics/straggler_handling_algorithms.rst
Outdated
Show resolved
Hide resolved
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Please update the relevant module(s) under API reference.
Edit: @ishant162 Verify the links by rebuilding and running the documentation locally. Build instructions provided under contribution guidelines on the docsite.
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
Folks, this PR is taking a little too long to merge. Can we try closing it this week? |
Hi @MasterSkepticista, Note: The links to the source code for straggler handling policies are currently broken as they point to |
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
This pull request is a follow-up to the Straggler Handling PR #996 . Based on the feedback from @MasterSkepticista and @teoparvanov , the review comments have been addressed and incorporated accordingly.
Summary of changes:
Relocated straggler_handling to the
openfl/component/aggregator
directory.Consolidated all policies into
openfl/component/aggregator/straggler_handling.py
Renamed
CutoffTimeBasedStragglerHandling
toCutoffTimePolicy
andPercentageBasedStragglerHandling
toPercentagePolicy
Removed the attribute deletion functionality from
CutoffTimePolicy
Validate OpenFL Security through regression testing