Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Straggler handling Follow-up #1097

Merged

Conversation

ishant162
Copy link
Collaborator

@ishant162 ishant162 commented Oct 23, 2024

This pull request is a follow-up to the Straggler Handling PR #996 . Based on the feedback from @MasterSkepticista and @teoparvanov , the review comments have been addressed and incorporated accordingly.

Summary of changes:

  • Relocated straggler_handling to the openfl/component/aggregator directory.

  • Consolidated all policies into openfl/component/aggregator/straggler_handling.py

  • Renamed CutoffTimeBasedStragglerHandling to CutoffTimePolicy and PercentageBasedStragglerHandling to PercentagePolicy

  • Removed the attribute deletion functionality from CutoffTimePolicy

  • Validate OpenFL Security through regression testing

@teoparvanov
Copy link
Collaborator

teoparvanov commented Oct 23, 2024

@ishant162 , did you test for regression by raising a PR in OpenFL-Security?

@scngupta-dsp
Copy link
Contributor

@ishant162 , did you test for regression by raising a PR in OpenFL-Security?

This needs to be done @teoparvanov . We will feedback once it is done

Copy link
Collaborator

@MasterSkepticista MasterSkepticista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good improvement over the previous layout.

Most suggestions, though seem like nitpicks, have measurable changes on developers and users in the look-and-feel of the framework. Please take a look.

openfl/component/aggregator/aggregator.py Outdated Show resolved Hide resolved
openfl/component/aggregator/aggregator.py Outdated Show resolved Hide resolved
openfl/component/aggregator/aggregator.py Outdated Show resolved Hide resolved
openfl/component/aggregator/straggler_handling.py Outdated Show resolved Hide resolved
openfl/component/aggregator/straggler_handling.py Outdated Show resolved Hide resolved
openfl/component/aggregator/straggler_handling.py Outdated Show resolved Hide resolved
openfl/component/aggregator/straggler_handling.py Outdated Show resolved Hide resolved
openfl/federated/plan/plan.py Outdated Show resolved Hide resolved
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
@ishant162 ishant162 marked this pull request as ready for review January 16, 2025 06:44
Copy link
Collaborator

@teoparvanov teoparvanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks @ishant162 ! I just have a couple of minor comments:

Copy link
Collaborator

@MasterSkepticista MasterSkepticista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update the relevant module(s) under API reference.

Edit: @ishant162 Verify the links by rebuilding and running the documentation locally. Build instructions provided under contribution guidelines on the docsite.

@MasterSkepticista
Copy link
Collaborator

Folks, this PR is taking a little too long to merge. Can we try closing it this week?

@ishant162
Copy link
Collaborator Author

ishant162 commented Jan 28, 2025

Hi @MasterSkepticista,
I’ve verified the links by running the documentation locally. The straggler_handling module is now part of the openfl.component.aggregator module.

Note: The links to the source code for straggler handling policies are currently broken as they point to securefederatedai/openfl. Since the straggler_handling module has been moved under the aggregator module, I expect these links to work correctly once this PR is merged.

Signed-off-by: Ishant Thakare <ishantrog752@gmail.com>
@teoparvanov teoparvanov merged commit c71080e into securefederatedai:develop Jan 30, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants