-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ordinal check when transfering BTC #365
Conversation
needs conflict resolved |
…-extension into imamahzafar/ordinal-check
The test scenarios in this pr are:
|
When I went through the send btc flow, and I had an ordinal in the btc address(but choose not to move it to the ordinal address) @yknl @Imamah-Zafar Is this the expected result in this scenario? |
from my understanding, yes that is why the alert is shown so the user can move the ordinal |
Note for me: waiting for this tx (https://mempool.space/tx/8b5acea32b4481a2385d0e253523ca5c1349c148764c0142006cfac28ecd4446) so I can check the scenario when I have the ordinal in the btc payment address and restore it before sending btc |
@Imamah-Zafar Needs typo fix in the h1 it should Restore Ordinals instead of Restore Oridnals |
When I chose to recover the ordinal in the send btc flow, it was displaying in the Restore BTC screen until it was pending. Eventually, the ordinal was displayed in the ordinal gallery, which is good 👍 https://mempool.space/tx/800fd2a599a0329e9f2094f55baac65d5087e4a62608f5599f57a9114230cd3f |
needs conflict to be resolved |
the transaction does show that the funds were transferred to ordinal address. input is the btc address and output is ordinal address |
Latest update after the daily: we need to handle the pending utxo's, so we need to handle it as well in the xverse-core as well. |
needs conflicts resolved |
…-extension into imamahzafar/ordinal-check
Just to confirm that the issue with the utxo pending displays at the recover btc screen - is not present on mobile. |
I need to recheck the flow one last time, waiting for this tx to go through https://mempool.space/tx/7b28c2357a40276fd3c33acd62393f67042b2bd2ace4f30cb975cbf58f55e60e |
this can be merged. 👍 |
PR Type
What kind of change does this PR introduce?
What is the current behavior?
(Optional) Resolved: #355
What is the new behavior?
Screenshot / Video
Figma link: https://www.figma.com/file/eUJAc1beEvNcLPGszkY1xo/Xverse-%E2%80%94-Extension?node-id=4249%3A133488&t=mJBbDnYRbQHFYzU7-1