-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handle when a tab that initiated a request is closed #201
Conversation
@Imamah-Zafar what dapp did you use to interact to get this alert message in the pop-up? |
i interacted with gamma and xverse web pool. This pr basically adds the functionality where if a user is making a transaction via dapp and the original dapp tab closes then in the xverse popup a message is shown that the tab that initated the request was closed. Open any dapp website( you can also use the test app for this) , trigger the pop up, when the xverse pop up shows. close the originating tab on chrome that initiated the request .now check the xverse pop up and you would be shown the message |
@Imamah-Zafar there is some conflicts on this one can you resolve them so we can merge |
…-extension into imamahzafar/tab-close-request
PR Type
What kind of change does this PR introduce?
What is the new behavior?
An alert message is shown if tab that initiated a request is closed
