Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle when a tab that initiated a request is closed #201

Merged
merged 5 commits into from
Jan 19, 2023

Conversation

Imamah-Zafar
Copy link
Contributor

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Enhancement
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the new behavior?

An alert message is shown if tab that initiated a request is closed
contract-alert

@Imamah-Zafar Imamah-Zafar self-assigned this Jan 11, 2023
@Imamah-Zafar Imamah-Zafar added the enhancement New feature or request label Jan 11, 2023
@Imamah-Zafar Imamah-Zafar linked an issue Jan 11, 2023 that may be closed by this pull request
m-aboelenein
m-aboelenein previously approved these changes Jan 16, 2023
@m-aboelenein m-aboelenein added this to the Sprint 25 - Jan 30 milestone Jan 16, 2023
@DuskaT021
Copy link
Contributor

DuskaT021 commented Jan 16, 2023

@Imamah-Zafar what dapp did you use to interact to get this alert message in the pop-up?
Could you give example of a user scenario, and I'll try it out on some other dapps?
I interacted with stacks explorer and gamma.io, couldn't get the alert in the pop-up ,might cause I missing context.
If I for example start off a process of deploying a contract (stacks explorer) with one account , and switch accounts before confirming the deploy contract action, I don't see the alert error message.

image

@Imamah-Zafar
Copy link
Contributor Author

@Imamah-Zafar what dapp did you use to interact to get this alert message in the pop-up? Could you give example of a user scenario, and I'll try it out on some other dapps? I interacted with stacks explorer and gamma.io, couldn't get the alert in the pop-up ,might cause I missing context. If I for example start off a process of deploying a contract (stacks explorer) with one account , and switch accounts before confirming the deploy contract action, I don't see the alert error message.

image

i interacted with gamma and xverse web pool. This pr basically adds the functionality where if a user is making a transaction via dapp and the original dapp tab closes then in the xverse popup a message is shown that the tab that initated the request was closed. Open any dapp website( you can also use the test app for this) , trigger the pop up, when the xverse pop up shows. close the originating tab on chrome that initiated the request .now check the xverse pop up and you would be shown the message

@m-aboelenein
Copy link
Member

@Imamah-Zafar there is some conflicts on this one can you resolve them so we can merge

@m-aboelenein m-aboelenein merged commit 78f3a82 into develop Jan 19, 2023
@m-aboelenein m-aboelenein deleted the imamahzafar/tab-close-request branch January 19, 2023 12:00
teebszet added a commit that referenced this pull request Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

handling when a tab that initiated a request is closed
4 participants