Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend supported fiat currencies to include Swiss Franc (CHF) #275

Merged
merged 2 commits into from
Nov 23, 2023

Conversation

baumea
Copy link
Contributor

@baumea baumea commented Nov 7, 2023

🔘 PR Type

  • Enhancement

📜 Background

Previously, xverse-core supported only to compute the conversion rates for USD, EUR, CAD, CNY, ARS, KRW, HKD, JPY, SGD, GBP, BRL, RUB. This PR extends the support to Swiss Francs. In fact, the xverse.app api for the mainnet as well as for the testnet support Swiss Francs already:

curl 'https://api-testnet.xverse.app/v1/prices/btc/CHF'
curl 'https://api-3.xverse.app/v1/prices/btc/CHF'

🔄 Changes

Does this PR introduce a breaking change?

  • Yes, Incompatible API changes
  • No, Adds functionality (backwards compatible)
  • No, Bug fixes (backwards compatible)

Changes:

  • Changes were only made to types/currency.ts

Impact:

  • Allows for other software, e.g., the xverse-web-extension, to compute the Swiss Francs conversion rates.

✅ Review checklist

Please ensure the following are true before merging:

  • Code Style is consistent with the project guidelines.
  • Code is readable and well-commented.
  • No unnecessary or debugging code has been added.
  • Security considerations have been taken into account.
  • The change has been manually tested and works as expected.
  • Breaking changes and their impacts have been considered and documented.
  • Code does not introduce new technical debt or issues.

Extend the list of supported fiat currencies to Swiss Francs (CHF).
@victorkirov
Copy link
Member

@baumea Thanks for submitting this PR. Sorry for the delay, I just saw it now. We'll try and push it in soon!

@teebszet teebszet merged commit a6d2ae3 into secretkeylabs:develop Nov 23, 2023
@github-actions github-actions bot mentioned this pull request Nov 24, 2023
teebszet pushed a commit that referenced this pull request Jan 9, 2025
* prepare todo

* lock

* make changes

* update comment

* revert lock file

* new format

* suggestion

* Update utils/numbersFormatting.ts

Co-authored-by: Victor Kirov <victor.kirov@gmail.com>

* Update utils/numbersFormatting.ts

Co-authored-by: Victor Kirov <victor.kirov@gmail.com>

* suggestions

* suggestions!

* Update utils/numbersFormatting.ts

Co-authored-by: Victor Kirov <victor.kirov@gmail.com>

---------

Co-authored-by: Victor Kirov <victor.kirov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants