Using @testWith annotation may generate PHP Warning: Uninitialized string offset 0

[staabm]

Closes #5795

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (1a63f0d) to head (9f951ca).

Additional details and impacted files

@@            Coverage Diff            @@
##               10.5    #5802   +/-   ##
=========================================
  Coverage     90.15%   90.15%           
- Complexity     6440     6441    +1     
=========================================
  Files           679      679           
  Lines         19545    19545           
=========================================
  Hits          17620    17620           
  Misses         1925     1925           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[staabm]

btw: I never seen this feature used in the wild. I am not sure when to use it, if one can use a regular DataProvider instead.

writing data for tests in a phpdoc comment, which will be parsed and mangled by a lot of other tools sounds like a footgun.

[sebastianbergmann]

I never seen this feature used in the wild

Me neither.

I am not sure when to use it, if one can use a regular DataProvider instead

This was proposed in #1151 and implemented in #1728. The argument was that "[data providers are] overcomplicated and require to[o] much code for most tasks".

I should have said "No!" at the time, but did not :-(

writing data for tests in a phpdoc comment, which will be parsed and mangled by a lot of other tools sounds like a footgun

At least this footgun will be gone once support for annotations in comments is removed.

[staabm]

I should have said "No!" at the time, but did not :-(

Without trying we wouldn't know. So it was a small failed experiment.. just look forward :-)