Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI to continue-on-error for PHP 8.4 #5522

Closed
wants to merge 1 commit into from
Closed

Update CI to continue-on-error for PHP 8.4 #5522

wants to merge 1 commit into from

Conversation

ghostwriter
Copy link
Contributor

Fix CI tests failing on PHP 8.4 due to missing extension, enabling continue-on-error in order to allow end-to-end-tests to run.

Related: #5521

@sebastianbergmann
Copy link
Owner

I have opened shivammathur/setup-php#769 for the underlying issue.

@sebastianbergmann
Copy link
Owner

Can we limit continue-on-error to PHP 8.4 on Windows?

@sebastianbergmann sebastianbergmann added platform/windows Issues specific to the Windows platform type/build-automation Issues related to PHPUnit's build automation (GitHub Actions, etc.) labels Sep 22, 2023
@sebastianbergmann
Copy link
Owner

@localheinz Do you see a way to only ignore PHP 8.4 on Windows? Thanks!

@localheinz
Copy link
Collaborator

@sebastianbergmann Will take a look in thirty minutes!

@localheinz localheinz self-assigned this Sep 22, 2023
Fix CI tests failing in PHP 8.4 due to missing extension, enabling `continue-on-error` for end-to-end tests.
@localheinz
Copy link
Collaborator

@ghostwriter @sebastianbergmann

Looks like we need to wait for shivammathur/setup-php#769!

@ghostwriter
Copy link
Contributor Author

@localheinz Thanks for your help.

@sebastianbergmann
Copy link
Owner

Thank you for your contribution. I appreciate the time you invested in preparing this pull request. However, I have decided not to merge it.

@ghostwriter ghostwriter deleted the patch-1 branch September 23, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/windows Issues specific to the Windows platform type/build-automation Issues related to PHPUnit's build automation (GitHub Actions, etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants