Provide distinct messages when a test is considered risky due to output buffering level mismatch #5343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TestCase@stopOutputBuffering()TestCase@stopOutputBuffering()
687e757 to
d36a8a8
Compare
|
Can you please send this against |
Codecov Report
@@ Coverage Diff @@
## 10.1 #5343 +/- ##
=========================================
Coverage 85.00% 85.01%
- Complexity 6059 6060 +1
=========================================
Files 651 651
Lines 19232 19235 +3
=========================================
+ Hits 16349 16352 +3
Misses 2883 2883
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
d36a8a8 to
01b797b
Compare
01b797b to
4cb0e6a
Compare
Done. Thank you! |
TestCase@stopOutputBuffering()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a test is marked risky if it didn't close its output buffer OR if it closed additional output buffers.
This PR will give the developer granularity to see which of the two cases caused the issue.