Closes #5612

sebastianbergmann · Dec 27, 2023 · d6e3b1f · d6e3b1f
1 parent fecca89
commit d6e3b1f
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 2 deletions.
diff --git a/ChangeLog-10.5.md b/ChangeLog-10.5.md
@@ -8,6 +8,7 @@ All notable changes of the PHPUnit 10.5 release series are documented in this fi
 
 * [#5592](https://github.com/sebastianbergmann/phpunit/issues/5592): Error Handler prevents `error_get_last()` usage in tests
 * [#5592](https://github.com/sebastianbergmann/phpunit/issues/5592): `E_USER_ERROR` does not abort test execution
+* [#5612](https://github.com/sebastianbergmann/phpunit/issues/5612): Empty `<coverage>` element in XML configuration after migrating configuration
 * [#5616](https://github.com/sebastianbergmann/phpunit/issues/5616): Values from data provider are not shown for failed test
 * [#5621](https://github.com/sebastianbergmann/phpunit/issues/5621): Name of data set is missing from TeamCity output
 

diff --git a/src/TextUI/Configuration/Xml/Migration/Migrations/MoveCoverageDirectoriesToSource.php b/src/TextUI/Configuration/Xml/Migration/Migrations/MoveCoverageDirectoriesToSource.php
@@ -50,5 +50,11 @@ public function migrate(DOMDocument $document): void
                 $source->appendChild($node);
             }
         }
+
+        if ($coverage->childElementCount !== 0) {
+            return;
+        }
+
+        $coverage->parentNode->removeChild($coverage);
     }
 }
diff --git a/tests/_files/XmlConfigurationMigration/output-9.5.xml b/tests/_files/XmlConfigurationMigration/output-9.5.xml
@@ -6,8 +6,6 @@
          cacheDirectory=".phpunit.cache"
          requireCoverageMetadata="true">
 
-    <coverage/>
-
     <logging/>
 
     <source>