feat: Epitaph Road #619

pacampbell · 2024-10-27T14:13:13Z

Added support for Epitaph Road endgame content.

Implemented the personal quest to enter "Heroic Spirit Sleeping Path:
Rathnite Foothills".
Created new epitaph assets which describe the different paths,
sections and trials.
Implemented multiple packet handlers for different season dungeon
packets.
Implemented queued packet handler which enables packets to be send
after the response is sent.
Implemented sections 1, 2, 3 and 4 for Rathnite Foothills
Implemented the final trial for Rathnite Foothills
Implemented sections 1 and 3 for Memory of Megadosys.

Checklist:

The project compiles
The PR targets develop branch

- Implemented many req, res, ntc and handlers for Epitaph content. - Renamed existing BonusDungeonManager to DungeonManager. - Implemented database migration from 24 -> 25. - Implemented a new packet handler which provides a queue which can be used to send packets after the response is returned. - Commented out RPC ping print message. - Added new NPC behavior to NpcGetExtendedFacilityHandler.

- Created personal quest required to enter Rathnite Foothills dungeon. - Created new EpitaphRoad.json file which contains dungeon information for each path. - Created new epitaph directory to hold all trials - Implemented all trials for Rathnite foothills. - Implemented section 1 and section 3 trials for Memory of Megadosys.

- Added docs which contain information found about buffs, objectives and rewards. - Started a new document guide.md which describes the epitaph assets.

- Added new enemies for the Rathnite Foothills dungeon. - Added some enemies to memory of megadosys.

RyanYappert · 2024-11-25T01:08:04Z

Arrowgene.Ddon.GameServer/Characters/CharacterManager.cs

@@ -59,6 +59,14 @@ public Character SelectCharacter(uint characterId, DbConnection? connectionIn =
                return null;
            }

+            character.EpitaphRoadState.UnlockedContent = _Server.Database.GetEpitaphRoadUnlocks(character.CharacterId);


At some point we need to move a lot of this into a transaction and/or make this more modular. Fetching a character shouldn't involve a dozen DB opens and closes, and not every character fetch needs every detail.

I'm not sure what you mean by this. Every character needs the details populated. Old logic should be moved into the character manager instead of the way it was originally designed so we can move the transaction logic into these functions.

Can you attempt to check the profile of characters on other channels? I can't remember. If you can, you definitely need some of their details but you certainly don't need their Epitaph road state.

See also the current implementation in PawnRentRegisteredPawnHandler, where we have to do a full fetch of the owner's details just to get their inventory.

This function is called when you log in. It manages collecting and calculating stats from BO trees, pawns and all the other auxiliary information. It should only be called once (or maybe twice because we query twice at login for some reason).

I see it got used in some of these pawn ones. Maybe we should make a lighter ones for those? Problem is pawns need the character inventory and all that other unpleasant stuff.

RyanYappert · 2024-11-25T01:47:55Z

Arrowgene.Ddon.Rpc/RpcServer.cs

@@ -21,7 +21,7 @@ public RpcServer(DdonGameServer gameServer)
        public RpcCommandResult Execute(IRpcCommand command)
        {
            RpcCommandResult result = command.Execute(_gameServer);
-            Logger.Info(result.ToString());
+            // Logger.Info(result.ToString());


As I continue to add RPC stuff, I do think we need to have logging for it. Maybe in a better form than it currently is, but it should be there in some form.

This log spams so often, it gets in the way of reading the logs when ddon-tools is connected. We should make some filter system for this so we only get logs we want.

Not against removing this comment. It's true it gets spammy and i don't think we're getting much info out of it

- Add cancel handler - Fix bug when party ready/unready logic - Add missing connectionIn to DB queries - Fix argument id in om command - Fix issue where repop NTC was only sent to the player who killed the enemy. - Changed certain OM update packets to only send to the client who requested. - Fix barrier purchase so it only unlocks for the person who bought.

alborrajo

These features are getting crazy complicated, good job on it.
I haven't focused too much on the packets, managers, and handlers as i trust that they work, the comments im giving are mostly nitpicks, places where i feel are missing comments or explaining where certain values come from, and suggestions that you can freely ignore if you wish.

alborrajo · 2024-11-25T19:13:14Z

Arrowgene.Ddon.Database/Files/Database/Script/schema_sqlite.sql

+	CONSTRAINT "fk_ddon_epitaph_road_unlocks_character_id" FOREIGN KEY ("character_id") REFERENCES "ddon_character"("character_id") ON DELETE CASCADE
+);
+
+CREATE TABLE IF NOT EXISTS ddon_epitaph_claimed_weekly_rewards (


As an idea you could evaluate, rather than periodically cleaning up this table, you could store a timestamp and make sure there's no entry from the current week

alborrajo · 2024-11-25T19:19:11Z

Arrowgene.Ddon.GameServer/Characters/EpitaphRoadManager.cs

+                    // result as seen in player videos
+                    results.Add(new InstancedGatheringItem()
+                    {
+                        ItemId = (gatheringPoint == null) ? 9393 : dungeonInfo.SoulItemId,


Should these magic numbers be configurable? Or at least be named constants

I suppose this could be more robust than it currently is. Will add a TODO for now to make it more configurable.

Arrowgene.Ddon.GameServer/Chat/Command/Commands/UpdateOmCommand.cs

alborrajo · 2024-11-25T19:22:38Z

Arrowgene.Ddon.GameServer/GatheringItems/InstanceEpitaphRoadDropItemManager.cs

+            return 0;
+        }
+
+        private readonly List<(EpitaphBuffId BuffId, uint ItemId, uint Amount, double Chance)> gDropConfigs = new List<(EpitaphBuffId BuffId, uint ItemId, uint Amount, double Chance)>()


Same comment as before, should these be configurable? If they should but it's not done yet please leave a TODO. If they shouldn't be configurable a named constant or a comment explaining would be useful

They could be configurable, will add a TODO. They are used for adding bonus items from the epitaph buffs.

Arrowgene.Ddon.GameServer/Handler/InstanceGetEnemySetListHandler.cs

Arrowgene.Ddon.Shared/Entity/PacketStructure/C2S_SEASON_DUNGEON_62_12_16_NTC.cs

Arrowgene.Ddon.Shared/Entity/PacketStructure/S2CSeasonDungeonReceiveSoulOrdealRewardRes.cs

Arrowgene.Ddon.Shared/Entity/PacketStructure/S2CSeasonDungeonSetOmStateNtc.cs

Arrowgene.Ddon.Shared/Entity/PacketStructure/S2CStageGetSpAreaChangeInfoRes.cs

Arrowgene.Ddon.Shared/Entity/Structure/CDataSeasonDungeonBuffEffectReward.cs

- Added missing object instantiations to packet consturctors. - Renamed packets which were not named correctly. - Added some TODO comments

pacampbell force-pushed the epitaph_road branch 11 times, most recently from 2756a27 to db4c6e4 Compare November 3, 2024 02:44

pacampbell force-pushed the epitaph_road branch 7 times, most recently from ad2777a to 6c85168 Compare November 11, 2024 01:09

pacampbell force-pushed the epitaph_road branch 12 times, most recently from 687996c to 3f2e4af Compare November 18, 2024 15:05

pacampbell force-pushed the epitaph_road branch 11 times, most recently from 314aabc to 7071eaf Compare November 24, 2024 23:35

pacampbell added 4 commits November 24, 2024 19:01

docs: Add new docs for epitaph

e768534

- Added docs which contain information found about buffs, objectives and rewards. - Started a new document guide.md which describes the epitaph assets.

enemyspawn: Add enemies for Rathnite foothills

ebd1277

- Added new enemies for the Rathnite Foothills dungeon. - Added some enemies to memory of megadosys.

pacampbell force-pushed the epitaph_road branch from 7071eaf to ebd1277 Compare November 25, 2024 00:07

pacampbell marked this pull request as ready for review November 25, 2024 00:07

pacampbell requested review from RyanYappert and alborrajo November 25, 2024 00:07

RyanYappert approved these changes Nov 25, 2024

View reviewed changes

pacampbell force-pushed the epitaph_road branch 3 times, most recently from 6f60612 to 2aa0ce4 Compare November 25, 2024 05:55

pacampbell force-pushed the epitaph_road branch from 2aa0ce4 to 423eb1e Compare November 25, 2024 06:01

alborrajo reviewed Nov 25, 2024

View reviewed changes

code review feedback

843737c

- Added missing object instantiations to packet consturctors. - Renamed packets which were not named correctly. - Added some TODO comments

pacampbell requested a review from alborrajo November 26, 2024 14:19

pacampbell merged commit 2b148dc into sebastian-heinz:develop Nov 26, 2024
1 check passed

pacampbell mentioned this pull request Jan 5, 2025

Epitaph Road Tracker #683

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Epitaph Road #619

feat: Epitaph Road #619

pacampbell commented Oct 27, 2024 •

edited

Loading

RyanYappert Nov 25, 2024

pacampbell Nov 25, 2024

RyanYappert Nov 25, 2024

pacampbell Nov 25, 2024 •

edited

Loading

pacampbell Nov 25, 2024

RyanYappert Nov 25, 2024

pacampbell Nov 25, 2024

alborrajo Nov 25, 2024

alborrajo left a comment

alborrajo Nov 25, 2024

alborrajo Nov 25, 2024

pacampbell Nov 26, 2024 •

edited

Loading

alborrajo Nov 25, 2024

pacampbell Nov 26, 2024 •

edited

Loading

feat: Epitaph Road #619

feat: Epitaph Road #619

Conversation

pacampbell commented Oct 27, 2024 • edited Loading

Checklist:

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pacampbell Nov 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alborrajo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pacampbell Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pacampbell Nov 26, 2024 • edited Loading

Choose a reason for hiding this comment

pacampbell commented Oct 27, 2024 •

edited

Loading

pacampbell Nov 25, 2024 •

edited

Loading

pacampbell Nov 26, 2024 •

edited

Loading

pacampbell Nov 26, 2024 •

edited

Loading