forked from YotpoLtd/resec
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
health check and status interface #62
Open
peterfroehlich
wants to merge
18
commits into
seatgeek:master
Choose a base branch
from
gutefrage:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added a feature announcing elected master to zookeeper. |
Hi, thank you for this contribution. It would be cool if it merged, especially the health check route ... :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using resec on Nomad and ran into race conditions on deployments with our bigger clusters (>5gb data).
We implemented an health check interface to monitor if all data synced successfully. Nomad can use this to control the deployment process and only progresses if the instance is in sync and ready. We are using this on our production systems and deployments work well now.
Additionally the http interface exposes the resec states and redis info output as well. The interface is disabled by default and the listen address can be configured.
I've added an example with a more complex Nomadconfig, with health checking, blue/green deployment and metrics sidecar as well.