Create MetadataAPI interface

getMetadata cannot be exported as a standalone function. It turns out that you can no longer stub free-standing functions in Typescript 3.9.2+ according to this issue:

microsoft/TypeScript#38568
sinonjs/sinon#562

src/client/api/__tests__/metadata.test.ts

@@ -8,7 +8,7 @@ import {
   rawSemesterList,
   error,
 } from 'common/data';
-import * as api from 'client/api';
+import { MetadataAPI } from 'client/api/metadata';
 import {
   strictEqual,
   deepStrictEqual,
@@ -39,7 +39,7 @@ describe('Metadata API', function () {
                 .map(({ term, year }): string => `${term} ${year}`),
             },
           } as AxiosResponse<MetadataResponse>);
-          result = await api.getMetadata();
+          result = await MetadataAPI.getMetadata();
         });
         it('should call getMetadata', function () {
           strictEqual(getStub.callCount, 1);
@@ -64,7 +64,7 @@ describe('Metadata API', function () {
         });
         it('should throw an error', async function () {
           try {
-            await api.getMetadata();
+            await MetadataAPI.getMetadata();
             fail('Did not throw an error');
           } catch (err) {
             deepStrictEqual(err, error);

src/client/api/metadata.ts

@@ -4,7 +4,11 @@ import request from './request';
 /**
  * Get the current metadata
  */
-export const getMetadata = async (): Promise<MetadataResponse> => {
+const getMetadata = async (): Promise<MetadataResponse> => {
   const response = await request.get('/api/metadata/');
   return response.data as MetadataResponse;
 };
+
+export const MetadataAPI = {
+  getMetadata,
+};

src/client/components/App.tsx

@@ -35,7 +35,7 @@ import {
 import { UserAPI } from 'client/api';
 import { UserResponse } from 'common/dto/users/userResponse.dto';
 import { MetadataContext } from 'client/context/MetadataContext';
-import { getMetadata } from 'client/api/metadata';
+import { MetadataAPI } from 'client/api/metadata';
 import { Message } from './layout';
 import NoMatch from './pages/NoMatch';
 import logo from '../img/seas-logo.svg';
@@ -112,7 +112,7 @@ export const ColdApp: SFC = (): ReactElement => {
   });
 
   useEffect((): void => {
-    getMetadata()
+    MetadataAPI.getMetadata()
       .then((metadata): void => {
         setMetadata(metadata);
       })

src/client/components/__tests__/App.test.tsx

@@ -8,7 +8,7 @@ import {
 import { render as customRender } from 'test-utils';
 import { metadata } from 'common/data/metadata';
 import { stub, SinonStub } from 'sinon';
-import * as metaApi from 'client/api/metadata';
+import { MetadataAPI } from 'client/api/metadata';
 import * as dummy from 'common/data';
 import { UserAPI } from 'client/api';
 import { MemoryRouter } from 'react-router-dom';
@@ -20,7 +20,7 @@ describe('App', function () {
   let dispatchMessage: SinonStub;
   beforeEach(function () {
     userStub = stub(UserAPI, 'getCurrentUser');
-    metaStub = stub(metaApi, 'getMetadata');
+    metaStub = stub(MetadataAPI, 'getMetadata');
     dispatchMessage = stub();
     userStub.resolves(dummy.regularUser);
     metaStub.resolves(dummy.metadata);