Make file serving helpers public #924
Conversation
|
@seanmonstar I'm slightly unsure about how you want some of these internals documented. I've mentioned you in the code for |
None of this has been tested yet, so there will likely be bugs. We now depend on my fork of Warp until [this](seanmonstar/warp#924) is merged.
* refactor: moved some functions for integrations into the core package This will make developing more integrations in future much simpler. This also involved standardizing the `Options` taken by all integrations BREAKING CHANGE: `Options` renamed to `ServerOptions` for all integrations * feat: made templates and error pages thread-safe This involved adding an atomic types system. Also added basics for a Warp integration (which needs this thread-safety). * feat: made more things thread-safe and made warp integration nearly work The problem is `Rc<Translator>`s, so some refactoring needs to be done. * feat: added nearly all handlers to warp integration BREAKING_CHANGE: `ServerOptions` now only accepts one static content directory * fix: made `DummyTranslator` `Clone`able * feat: added support for static aliases in the warp integration None of this has been tested yet, so there will likely be bugs. We now depend on my fork of Warp until [this](seanmonstar/warp#924) is merged. * fix: pinned `clap` version Fixes #85. * feat: finalized warp integration It's also now the default in the CLI. * docs: updated docs to reflect warp integration * docs: merged `next` and `0.3.x` docs * chore: extended version replacement script Now covers the `Cargo.toml` files in `examples/basic/.perseus`.
|
@seanmonstar is there anything blocking this in particular? |
|
Okay, not sure if anyone is going to review this but for anyone with the same problems as in #171 I published a temporary fix crate (I needed this immediately) as Obviously, if this gets merged I'll deprecate that crate. |
|
Yep, the comments look a lot better now and will be very useful to developers. 👍🏻 |
|
@seanmonstar are there any plans to merge this? I'm very happy to update this to be in sync with |
|
@seanmonstar would be great to get this merged! blocking something i'm working on 🙏 |
|
@quinn if it helps there's my public |
|
@seanmonstar I notice the repo has had some activity lately, any chance of this being merged? I've updated everything to be in sync with the master branch. (For others: until this is merged, I've released another version of the |
| #[derive(Debug, Default)] | ||
| pub struct Conditionals { | ||
| /// Only respond with the file if it has been modified since this date. [See MDN](https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/If-Modified-Since). | ||
| pub if_modified_since: Option<IfModifiedSince>, |
There was a problem hiding this comment.
I would keep the fields private. That way we can add more, or change them. We also haven't exposed the headers crate publicly.
| #[derive(Clone, Debug)] | ||
| struct ArcPath(Arc<PathBuf>); | ||
| pub struct ArcPath(pub Arc<PathBuf>); |
| /// | ||
| /// Usually, you'll want to use this with `warp::fs::file`, but if the file's path is based on something extracted with a filter, | ||
| /// you'll need to use this manually. | ||
| pub fn file_reply( |
|
Yeah you're right that is much cleaner, I'll refactor this PR as soon as I can. (Terribly sorry for the late reply by the way, I've been really busy the last month!) |
|
Closing because #1049 supersedes this (according to its description). |
This makes some of the contents of fs.rs public so that users can serve static files at paths based on the request without having to implement file streaming manually.
Fixes #171.