Add serde support #41
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job #134.4 failed because |
|
I implemented this before in #21 but @seanmonstar wrote in that PR why he didn't want it merged. I agree with other posters that due to serde-rs/serde#723, this is a very significant omission. It leads to a very poor user experience, especially for first time Rust users (cf. lawliet89/unicase_serde#1). I urge @seanmonstar to consider merging this. I would happily deprecated my |
KamilaBorowska
suggested changes
Apr 9, 2021
| @@ -74,6 +74,7 @@ use self::unicode::Unicode; | |||
|
|
|||
| mod ascii; | |||
| mod unicode; | |||
| pub mod serde; | |||
There was a problem hiding this comment.
Suggested change
| pub mod serde; | |
| mod serde; |
I'm not seeing why this needs to be public. Trait implementations aren't part of a module.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #37
Add implementations of
SerializeandDeserializeforUniCaseandAsciibased on lawliet89/unicase_serde.As proposed by the rust api guidelines data structures should implement Serde's Serialize, Deserialize.
Serde is added as optional dependency which can be used as feature so that no breaking api changes are introduced.