Update `tokio` to 1.0 #1060

incker · 2020-10-17T10:08:46Z

New version of tokio is released
reqwest vesrion of tokio is 0.2 Cargo.toml

Better upgrade, to avoid downloading two versions of tokio in projects

jensim · 2020-10-18T04:47:28Z

This actually seems to prevent upstream binaries from upgrading to tokio:0.3.0.
I tried upgrading my cli app bitbucket_server_cli, here is the result trying to run with incompatible tokio-versions

thread 'main' panicked at 'there is no timer running, must be called from the context of Tokio runtime', /Users/jensim/.cargo/registry/src/github.com-1acb6219da9ec827/tokio-0.2.22/src/time/driver/handle.rs:25:14
stack backtrace:
   0:        0x10edea394 - <std::sys_common::backtrace::_print::DisplayBacktrace as core::fmt::Display>::fmt::hd4b962ed89f71a03
   1:        0x10ee0de10 - core::fmt::write::h94ae1e793baa7a00
   2:        0x10ede448b - std::io::Write::write_fmt::h5c716758fdc3057f
   3:        0x10edebf45 - std::panicking::default_hook::{{closure}}::hc6119c7d16548caf
   4:        0x10edebc87 - std::panicking::default_hook::heae8b62897b351dc
   5:        0x10edec4e5 - std::panicking::rust_panic_with_hook::hc36596b4257bea99
   6:        0x10edec07b - std::panicking::begin_panic_handler::{{closure}}::h49e5ddc3f21ca2fb
   7:        0x10edea808 - std::sys_common::backtrace::__rust_end_short_backtrace::h9bd32c9ad3fad18f
   8:        0x10edec03a - _rust_begin_unwind
   9:        0x10ee2619f - core::panicking::panic_fmt::hcdc9362d34d55302
  10:        0x10ee2602a - core::option::expect_failed::h2cf6417a1cce758c
  11:        0x10eda9147 - tokio::time::delay::delay_for::ha5c963747a903eaf
  12:        0x10eceb48d - reqwest::async_impl::client::Client::execute_request::hf7a8c0de5eae6488
  13:        0x10ed284e2 - reqwest::async_impl::request::RequestBuilder::send::hcf6b3611e4279255
  14:        0x10ea49476 - bitbucket_server_cli::bitbucket::worker::BitbucketWorker::fetch_all_user_repos::{{closure}}::hddcb554493bccb0e
  15:        0x10ea5ad7d - <core::future::from_generator::GenFuture<T> as core::future::future::Future>::poll::hf40a34645155b35e
  16:        0x10ea32b81 - std::thread::local::LocalKey<T>::with::hc20d5bef6701544d
  17:        0x10ea389f7 - tokio::runtime::enter::Enter::block_on::h9eb328f39405ec67
  18:        0x10ea3cea5 - tokio::runtime::thread_pool::ThreadPool::block_on::h4174e4a4d5e0c544
  19:        0x10ea69bed - tokio::runtime::Runtime::block_on::h2bc0cb0537fac7ec
  20:        0x10ea354de - bitbucket_server_cli::main::h07f0683523971a5d
  21:        0x10ea6397a - std::sys_common::backtrace::__rust_begin_short_backtrace::h12ac5d6b20230f57
  22:        0x10ea6399c - std::rt::lang_start::{{closure}}::h771a80e1366e93a1
  23:        0x10edec880 - std::rt::lang_start_internal::hd0c760d47f593c0a
  24:        0x10ea355b9 - _main

jensim · 2020-10-18T04:59:33Z

Looking at reqwest dependency tree we are also blocked by the dependency chain

➜  reqwest git:(master) cargo tree -i tokio
tokio v0.2.22
├── h2 v0.2.6
│   └── hyper v0.13.8
│       ├── hyper-tls v0.4.3
│       │   └── reqwest v0.10.8 (/Users/jenbri/vcs/github/reqwest)
│       └── reqwest v0.10.8 (/Users/jenbri/vcs/github/reqwest)
│       [dev-dependencies]
│       └── reqwest v0.10.8 (/Users/jenbri/vcs/github/reqwest)
├── hyper v0.13.8 (*)
├── hyper-tls v0.4.3 (*)
├── reqwest v0.10.8 (/Users/jenbri/vcs/github/reqwest)
├── tokio-tls v0.3.1
│   ├── hyper-tls v0.4.3 (*)
│   └── reqwest v0.10.8 (/Users/jenbri/vcs/github/reqwest)
└── tokio-util v0.3.1
    └── h2 v0.2.6 (*)
[dev-dependencies]
└── reqwest v0.10.8 (/Users/jenbri/vcs/github/reqwest)

pomazanbohdan · 2020-10-22T08:47:25Z

issue: seanmonstar/reqwest#1060

pomazanbohdan · 2020-11-05T08:56:52Z

enarx-archive/enarx-keepmgr#10
robotty/recent-messages2#68
dmolokanov/appinsights-rs#131
1tgr/rust-websocket-lite#118
IronCoreLabs/ironoxide#194
IronCoreLabs/ironoxide-cli#38
testcontainers/testcontainers-rs#221
Idein/dockworker#99
camallo/dkregistry-rs#188

messense · 2020-11-06T09:02:02Z

#1076

Use asynchronous execution using tokio, switch to the influxdb crate, which uses reqwests (in its asynchronous APIs). Downgrade to tokio 0.2.x, because mixing 0.2.x and 0.3.x in the same process does not work. See seanmonstar/reqwest#1060.

Use asynchronous execution using tokio, update to a newer influxdb crate that uses reqwests. Downgrade to tokio 0.2.x, because mixing 0.2.x and 0.3.x in the same process does not work. See seanmonstar/reqwest#1060.

…onstar/reqwest#1060

ghost · 2020-11-19T14:08:36Z

N.B. this also means that trying to use reqwest from a tokio 0.3 runtime will give you this rather cryptic panic: tokio-rs/tokio#1837

mleonhard · 2020-11-23T17:54:44Z

@seanmonstar Is there anything I can do to help get this done faster? Could we do a point release?

seanmonstar · 2020-11-23T18:00:40Z

This is waiting on hyper 0.14, which can be tracked here: https://github.com/hyperium/hyper/milestone/6

Progress keeps being made there :)

This is a known issue: seanmonstar/reqwest#1060.

mleonhard · 2020-11-25T00:03:35Z

I got reqwest to compile by cloning patched versions of reqwest, hyper, and hyper-rustls and modifying their Config.toml files:

https://github.com/messense/reqwest.git
- git checkout #a3da4e094ede0f3c3ac45a2215742315b61dacca@tokio-0-3
- Modify Cargo.toml and update dependency statements:
  - http-body = { git = "https://github.com/hyperium/http-body", rev = "5e434739" }
  - hyper = { path = "../hyper", default-features = false, features = ["tcp", "http1", "http2", "client"] }
  - hyper-rustls = { path = "../hyper-rustls", default-features = false, optional = true }
  - hyper-tls = { path = "../hyper-tls", optional = true }
https://github.com/hyperium/hyper.git
- git checkout #121c33132c0950aaa422848cdc43f6691ddf5785
- Modify Cargo.toml and update dependency statements:
  - http-body = { git = "https://github.com/hyperium/http-body", rev = "5e434739" }
https://github.com/ctz/hyper-rustls.git
- git checkout #e7f38abb797ef08039542b72ef6689a38102f7df
- Modify Cargo.toml and update dependency statements:
  - hyper = { path = "../hyper", default-features = false }
https://github.com/messense/hyper-tls.git (if not using feature rustls-tls)
- git checkout #07dc2306696b83d1a16476ea04c8c0755e6bff9d@bump-tokio
- Modify Cargo.toml and update dependency statements:
  - hyper = { path = "../hyper", default-features = false, features = ["tcp", "client", "http1"] }

My project's integration test now builds and runs. The Cargo.toml has:

[dependencies]
rustls = "0.18"
tokio = { version = "0.3", features = ["macros", "stream", "sync", "time"] }
tokio-rustls = "0.20"

[dev-dependencies]
reqwest = { path = "../deps/reqwest", features = ["rustls-tls"] }
tokio = { version = "0.3", features = ["fs", "macros", "net", "rt-multi-thread", "signal"] }
tokio-test = "0.3"

Thank you, all of you who are updating reqwest and its dependencies! :)

EDIT: Add rustls-tls feature config.

krojew · 2020-12-23T19:15:21Z

Looks like we have tokio 1.0 available along with new hyper.

sinanameh · 2020-12-28T11:28:44Z

@seanmonstar Is there anything I can do to help get this done faster? Could we do a point release?

jplatte · 2020-12-28T11:37:19Z

@sinanameh hyper-tls needs to have hyperium/hyper-tls#79 merged and a new version released first.

ikkerens · 2021-01-01T17:41:29Z

hyper-tls has released v0.5.0 for tokio 1.0, so that's one blocker gone.
Any further blockers?

seanmonstar · 2021-01-05T17:38:24Z

This was done in #1076. Release coming today.

Mubelotix mentioned this issue Oct 19, 2020

Upgrade tokio from 0.2 to 0.3 meilisearch/meilisearch-rust#57

Closed

julien1619 mentioned this issue Oct 20, 2020

Upgrade tokio to 1.0 Creatiwity/siren#178

Merged

4 tasks

ThouCheese mentioned this issue Oct 21, 2020

Support for Tokio 0.3 ThouCheese/cloud-storage-rs#41

Closed

pomazanbohdan mentioned this issue Oct 22, 2020

Upgrade to tokio v0.3 teloxide/teloxide#292

Closed

andrey-yantsen mentioned this issue Oct 22, 2020

Bump tokio from 0.2.22 to 0.3.6 andrey-yantsen/plex-api.rs#91

Merged

This was referenced Oct 22, 2020

use TokenCredential in services Azure/azure-sdk-for-rust#59

Merged

upgrade to tokio 1.0 Azure/azure-sdk-for-rust#60

Closed

rossnomann mentioned this issue Oct 24, 2020

Upgrade to tokio 1.0 tg-rs/tgbot#3

Closed

pomazanbohdan mentioned this issue Oct 25, 2020

Upgrade to Tokio v1 seanmonstar/warp#725

Closed

3 tasks

jeremyandrews mentioned this issue Oct 25, 2020

[WIP] Upgrade to Tokio 0.3 tag1consulting/goose#205

Closed

rhysd mentioned this issue Oct 27, 2020

Upgrade to tokio v1 rhysd/git-brws#29

Closed

wayofthepie mentioned this issue Oct 29, 2020

Bump tokio from 0.2.22 to 0.3.2 wayofthepie/ctlogs-cli#69

Closed

jeremyandrews mentioned this issue Nov 1, 2020

Upgrade to Tokio 1.x tag1consulting/goose#213

Merged

lewisboon mentioned this issue Nov 1, 2020

RUSTSEC-2020-0016: net2 crate has been deprecated; use socket2 instead lewisboon/doclink-checker#2

Open

olback mentioned this issue Nov 2, 2020

tokio 0.3 olback/gnome-twitch-2#9

Open

JonaC22 mentioned this issue Nov 2, 2020

chore(deps): update tokio requirement from 0.2.22 to 0.3.3 JonaC22/portfolio-cli#3

Closed

fplust added a commit to fplust/bilibili-live-danmu that referenced this issue Nov 4, 2020

wait for reqwest update tokio to 0.3

0ac93f4

issue: seanmonstar/reqwest#1060

steveej mentioned this issue Nov 5, 2020

build(deps): update tokio requirement from 0.2 to 0.3 camallo/dkregistry-rs#188

Closed

steveej mentioned this issue Nov 9, 2020

[B-03499] update tokio to 0.3 holochain/holochain#461

Closed

2 tasks

clux mentioned this issue Nov 11, 2020

tokio 1.0 kube-rs/kube#339

Closed

2 tasks

dabreegster added a commit to a-b-street/abstreet that referenced this issue Nov 12, 2020

Downgrade tokio. aa966d7 broke headless and updater. Blocked on seanm…

b9bf23e

…onstar/reqwest#1060

jokeyrhyme mentioned this issue Nov 17, 2020

proposal: track executor/reactor independence? rust-lang/areweasyncyet.rs#34

Open

pacman82 mentioned this issue Nov 20, 2020

Update to tokio 0.3 pacman82/throttle#36

Closed

nick96 added a commit to nick96/sidre that referenced this issue Nov 24, 2020

Downgrade tokio to ver 0.2 as it's breaking the build

ed5def7

This is a known issue: seanmonstar/reqwest#1060.

justinmoon mentioned this issue Nov 25, 2020

[blockchain] Upgrade tokio bitcoindevkit/bdk#174

Merged

fanatid mentioned this issue Nov 30, 2020

Upgrade dependencies to tokio 1.0 vectordotdev/vector#5175

Closed

28 tasks

mre mentioned this issue Nov 30, 2020

Update dependencies (reqwest 0.11 and tokio 1.0) lycheeverse/lychee#51

Merged

janosimas mentioned this issue Dec 13, 2020

Iced 0.2 Migration iced-rs/iced#661

Closed

This was referenced Dec 14, 2020

Update tokio requirement from 0.2.22 to 0.3.5 ramsayleung/rspotify#162

Closed

Upgrade to Tokio 1.0 ramsayleung/rspotify#164

Closed

appaquet mentioned this issue Dec 15, 2020

Bump libp2p + tokio appaquet/exocore#458

Merged

This was referenced Dec 18, 2020

Deprecated crate warning from cargo audit #972

Closed

RUSTSEC-2020-0016: net2 crate has been deprecated; use socket2 instead Nadrieril/dhall-rust#206

Closed

mibes mentioned this issue Dec 22, 2020

Upgrade to tokio 1.0 mibes/couch-rs#4

Closed

incker changed the title ~~tokio = "0.3.0"~~ Update tokio to 1.0 Dec 24, 2020

davidgraeff mentioned this issue Dec 26, 2020

Async/Await support davidgraeff/firestore-db-and-auth-rs#10

Closed

seanmonstar closed this as completed Jan 5, 2021

innobead mentioned this issue Jan 28, 2021

Update reqwest to support tokio 1.0 innobead/huber#19

Closed

pomazanbohdan mentioned this issue Apr 27, 2021

Upgrade to tokio v0.3 teloxide/teloxide#374

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update `tokio` to 1.0 #1060

Update `tokio` to 1.0 #1060

incker commented Oct 17, 2020 •

edited

Loading

jensim commented Oct 18, 2020

jensim commented Oct 18, 2020 •

edited

Loading

pomazanbohdan commented Oct 22, 2020 •

edited

Loading

pomazanbohdan commented Nov 5, 2020 •

edited

Loading

messense commented Nov 6, 2020

ghost commented Nov 19, 2020

mleonhard commented Nov 23, 2020

seanmonstar commented Nov 23, 2020

mleonhard commented Nov 25, 2020 •

edited

Loading

krojew commented Dec 23, 2020

sinanameh commented Dec 28, 2020

jplatte commented Dec 28, 2020

ikkerens commented Jan 1, 2021

seanmonstar commented Jan 5, 2021

Update tokio to 1.0 #1060

Update tokio to 1.0 #1060

Comments

incker commented Oct 17, 2020 • edited Loading

jensim commented Oct 18, 2020

jensim commented Oct 18, 2020 • edited Loading

pomazanbohdan commented Oct 22, 2020 • edited Loading

pomazanbohdan commented Nov 5, 2020 • edited Loading

messense commented Nov 6, 2020

ghost commented Nov 19, 2020

mleonhard commented Nov 23, 2020

seanmonstar commented Nov 23, 2020

mleonhard commented Nov 25, 2020 • edited Loading

krojew commented Dec 23, 2020

sinanameh commented Dec 28, 2020

jplatte commented Dec 28, 2020

ikkerens commented Jan 1, 2021

seanmonstar commented Jan 5, 2021

Update `tokio` to 1.0 #1060

Update `tokio` to 1.0 #1060

incker commented Oct 17, 2020 •

edited

Loading

jensim commented Oct 18, 2020 •

edited

Loading

pomazanbohdan commented Oct 22, 2020 •

edited

Loading

pomazanbohdan commented Nov 5, 2020 •

edited

Loading

mleonhard commented Nov 25, 2020 •

edited

Loading