Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add container image list for image spec #1960

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

starnop
Copy link
Collaborator

@starnop starnop commented Jan 6, 2023

Signed-off-by: yuxing.lyx yuxing.lyx@alibaba-inc.com

Describe what this PR does / why we need it

add container image list for sealer image spec

the end users can get container image list by sealer inspect and the developer can get the container image list by the key sealer.image.container.images from image annotations

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

after that, we also need to do the following:

  1. parse and store the container image list when the build phase
  2. add a flag for sealer inspect to decide whether to output the list of images because of container image list could be a huge number

Signed-off-by: yuxing.lyx <yuxing.lyx@alibaba-inc.com>
@github-actions github-actions bot added the test label Jan 6, 2023
@codecov-commenter
Copy link

Codecov Report

Base: 17.47% // Head: 17.51% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (bc0b2c4) compared to base (b55f5b5).
Patch coverage: 31.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1960      +/-   ##
==========================================
+ Coverage   17.47%   17.51%   +0.04%     
==========================================
  Files         103      103              
  Lines        9169     9184      +15     
==========================================
+ Hits         1602     1609       +7     
- Misses       7355     7362       +7     
- Partials      212      213       +1     
Impacted Files Coverage Δ
pkg/define/image/v1/sealer_image_extension.go 0.00% <ø> (ø)
pkg/imageengine/buildah/inspect.go 0.00% <0.00%> (ø)
pkg/imageengine/buildah/sealer_image_extension.go 35.48% <63.63%> (+16.43%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@kakaZhou719 kakaZhou719 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants