bugfix: download images from imageListWithAuth.yaml #1835
Conversation
66cca80 to
757fc8a
Compare
Codecov ReportBase: 21.66% // Head: 21.65% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1835 +/- ##
==========================================
- Coverage 21.66% 21.65% -0.02%
==========================================
Files 72 72
Lines 6581 6586 +5
==========================================
Hits 1426 1426
- Misses 4969 4974 +5
Partials 186 186
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
if target image is already exist in building container, will skip to download it. |
I saw that |
| @@ -78,6 +78,9 @@ func NewBuildCmd() *cobra.Command { | |||
| }, | |||
| } | |||
| buildCmd.Flags().StringVarP(&buildFlags.Kubefile, "file", "f", "Kubefile", "Kubefile filepath") | |||
| //todo we can support imageList Flag to download extra container image rather than copy it to rootfs | |||
| buildCmd.Flags().StringVar(&buildFlags.ImageList, "image-list", "filepath", "`pathname` of imageList filepath, if set, sealer will read its content and download extra container") | |||
There was a problem hiding this comment.
what's the difference for image-list and image-list-with-auth?
And how about combine them?
There was a problem hiding this comment.
- image-list: extra container images list which is no auth required need to be saved to clusterimage.
- image-list-with-auth: extra container images list which is auth required need to be saved to clusterimage, see example: http://sealer.cool/docs/getting-started/build-cloudimage.html#more-build-examples
There was a problem hiding this comment.
what's the purpose for store the image list at present?
|
TODO: combine imageList and imageWithAuth @kakaZhou719 |
Describe what this PR does / why we need it
Does this pull request fix one issue?
Describe how you did it
add build flag
--image-list-with-authto support download container images from imageListWithAuth.yamlexample:
sealer build -t abc:v1 --image-list-with-auth imageListWithAuth.yamlif it set, sealer will read its content and download extra container images to rootfs.
Describe how to verify it
Special notes for reviews