Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move sealer cert command #1809

Merged
merged 2 commits into from
Oct 25, 2022
Merged

move sealer cert command #1809

merged 2 commits into from
Oct 25, 2022

Conversation

Stevent-fei
Copy link
Collaborator

Describe what this PR does / why we need it

move sealer cert command to cluster module

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@codecov-commenter
Copy link

codecov-commenter commented Oct 25, 2022

Codecov Report

Base: 21.55% // Head: 21.55% // No change to project coverage 👍

Coverage data is based on head (5b8aa0d) compared to base (dc7c336).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1809   +/-   ##
=======================================
  Coverage   21.55%   21.55%           
=======================================
  Files          72       72           
  Lines        6554     6554           
=======================================
  Hits         1413     1413           
  Misses       4958     4958           
  Partials      183      183           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@@ -35,7 +35,7 @@ You need to restart your API server manually after using sealer alpha cert. Then
var exampleForCertCmd = `
The following command will generate new api server cert and key for all control-plane certificates:

sealer alpha cert --alt-names 39.105.169.253,sealer.cool
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line:33 remove all alpha string

Copy link
Collaborator

@VinceCui VinceCui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@VinceCui VinceCui merged commit bb2d6bc into sealerio:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants