Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/new sealer ipv6 dual #1804

Merged
merged 8 commits into from
Oct 25, 2022
Merged

Conversation

VinceCui
Copy link
Collaborator

@VinceCui VinceCui commented Oct 24, 2022

Describe what this PR does / why we need it

Support deploy an ipv6 dual stack cluster.

Does this pull request fix one issue?

Describe how you did it

  • Support parse v6 ip;
  • Add v6 APIServer default VIP;
  • Configure dual ips in kubelet;

Describe how to verify it

First, for single stack cluster, need do nothing;

If you want to deploy dual stack cluster, specify your ClusterFile like this:

apiVersion: sealer.cloud/v2
kind: Cluster
metadata:
  name: my-cluster
spec:
  image: xxx
  env:
    - PodCIDR=5408:4003:10bb:6a01:83b9:6360:c66d:0000/112,12.96.0.0/16 # Use ',' to join double CIDR
    - SvcCIDR=6408:4003:10bb:6a01:83b9:6360:c66d:0000/112,102.96.0.0/16 # Use ',' to join double CIDR
    - IPv6DualStack=true # should be true
  ssh:
    passwd: "passwd"
  hosts:
    - ips:
        - 2408:4003:10c0:5300:d701:6b9e:dfa9:3df0
        - 2408:4003:10c0:5300:d701:6b9e:dfa9:3df1
      roles: [ master ] # add role field to specify the node role
    - ips:
        - 2408:4003:10c0:5300:d701:6b9e:dfa9:3df2
      roles: [ node ]

Special notes for reviews

Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>
Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>
Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>
Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>
Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>
Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>
@github-actions github-actions bot added the test label Oct 24, 2022
…6-dual

Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>

# Conflicts:
#	utils/ssh/connect.go
#	utils/ssh/platform.go
#	utils/ssh/scp.go
@github-actions github-actions bot removed the test label Oct 24, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 21.55% // Head: 21.70% // Increases project coverage by +0.14% 🎉

Coverage data is based on head (2ff6274) compared to base (dc7c336).
Patch coverage: 28.81% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1804      +/-   ##
==========================================
+ Coverage   21.55%   21.70%   +0.14%     
==========================================
  Files          72       72              
  Lines        6554     6557       +3     
==========================================
+ Hits         1413     1423      +10     
+ Misses       4958     4946      -12     
- Partials      183      188       +5     
Impacted Files Coverage Δ
pkg/runtime/kubernetes/kubeadm/kubeadm_config.go 15.78% <0.00%> (ø)
utils/net/iputils.go 30.63% <0.00%> (+5.39%) ⬆️
utils/net/route.go 0.00% <0.00%> (ø)
utils/ssh/connect.go 0.00% <0.00%> (ø)
utils/utils.go 0.00% <0.00%> (ø)
pkg/infradriver/ssh_infradriver.go 37.19% <25.00%> (-1.65%) ⬇️
pkg/clustercert/kube_certs.go 76.33% <50.00%> (ø)
pkg/ipvs/ipvs.go 88.88% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@allencloud
Copy link
Member

Could you add more details about pull request description? Excellent coder does much better in doc than his code. @VinceCui

@VinceCui
Copy link
Collaborator Author

This failed check i think is invaild.

@starnop
Copy link
Collaborator

starnop commented Oct 25, 2022

LGTM

@starnop starnop merged commit 234d5fc into sealerio:main Oct 25, 2022
Stevent-fei pushed a commit to Stevent-fei/sealer that referenced this pull request Oct 28, 2022
* Support ipv6 dual stack.

Signed-off-by: huaiyou <huaiyou.cyz@alibaba-inc.com>

bugfix: image save use ociv1 format (sealerio#1813)

* bugfix: image save use ociv1 format

* fix lint

clean /var/lib/sealer/data/linux_amd64_ before if exists (sealerio#1815)

Signed-off-by: zhy76 <958474674@qq.com>

Signed-off-by: zhy76 <958474674@qq.com>

delete cluster add prune options (sealerio#1793)

Signed-off-by: HIHIA <283304489@qq.com>

Signed-off-by: HIHIA <283304489@qq.com>

support sealer delete -f clusterfile flag

modify
Stevent-fei pushed a commit to Stevent-fei/sealer that referenced this pull request Oct 28, 2022
* Support ipv6 dual stack.

* bugfix: image save use ociv1 format

* fix lint

support sealer delete -f clusterfile flag

modify
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants