Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix k0s reset bug. #1753

Merged
merged 1 commit into from
Sep 30, 2022
Merged

Conversation

starComingup
Copy link
Member

Signed-off-by: starComingup 1225067236@qq.com

Describe what this PR does / why we need it

k0s nodes reset do not need to specify --config so this made sealer delete failed. In this PR, resolve this bug.
And master nodes will set default config path:/etc/k0s/k0s.yaml/ which same as our config path,

Does this pull request fix one issue?

NONE

Signed-off-by: starComingup <1225067236@qq.com>
@allencloud
Copy link
Member

Actually there are no test case for k0s now. So I am afraid that almost no one of maintainers has the ability to review your code. So I wish that we could add k0s test case or improve the test framework to guarantee the code update could satisfy the test case. How about that?

Although we have no test, for the pull request of this one, I could make it move on and merging. @starComingup

@starComingup
Copy link
Member Author

Actually there are no test case for k0s now. So I am afraid that almost no one of maintainers has the ability to review your code. So I wish that we could add k0s test case or improve the test framework to guarantee the code update could satisfy the test case. How about that?

Although we have no test, for the pull request of this one, I could make it move on and merging. @starComingup

@allencloud I have been tested it and fix problems one by one. As for auto build basefs, it need some time to do that. If somebody want to help me to test, I would appreciate it!
there is a public image can be used to test registry.cn-hangzhou.aliyuncs.com/starcoming/k0s:v1.24.4

@allencloud allencloud merged commit 05d696e into sealerio:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants