Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: image mount panic #1719

Merged
merged 1 commit into from
Sep 20, 2022

Conversation

tgfree7
Copy link
Contributor

@tgfree7 tgfree7 commented Sep 20, 2022

Signed-off-by: tgfree tgfree7@gmail.com

Describe what this PR does / why we need it

When mountinfo.GetMounts return an empty []*info, caused a panic.

Does this pull request fix one issue?

#1717

Describe how you did it

Describe how to verify it

Special notes for reviews

Signed-off-by: tgfree <tgfree7@gmail.com>
@tgfree7 tgfree7 mentioned this pull request Sep 20, 2022
@codecov-commenter
Copy link

Codecov Report

Base: 18.39% // Head: 18.39% // No change to project coverage 👍

Coverage data is based on head (c8b5edf) compared to base (18dcb8f).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1719   +/-   ##
=======================================
  Coverage   18.39%   18.39%           
=======================================
  Files          66       66           
  Lines        5359     5359           
=======================================
  Hits          986      986           
  Misses       4247     4247           
  Partials      126      126           
Impacted Files Coverage Δ
utils/mount/mount_service.go 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@justadogistaken justadogistaken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justadogistaken justadogistaken merged commit 4d88a6f into sealerio:main Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants