Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rust ClusterImage building related files #1517

Merged
merged 1 commit into from
Jun 16, 2022

Conversation

allencloud
Copy link
Member

Signed-off-by: Allen Sun shlallen1990@gmail.com

Describe what this PR does / why we need it

I remove rust ClusterImage building related files. Since I think this should be separated from the raw sealer project. @kakaZhou719 @bxy4543

Maybe it could be an independent repo in sealer org.

And we can file all these file in the commits before this pull request.

Does this pull request fix one issue?

none

Describe how you did it

none

Describe how to verify it

none

Special notes for reviews

none

Signed-off-by: Allen Sun <shlallen1990@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #1517 (f94992a) into main (f29986a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1517   +/-   ##
=======================================
  Coverage   10.68%   10.68%           
=======================================
  Files          84       84           
  Lines        7640     7640           
=======================================
  Hits          816      816           
  Misses       6721     6721           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29986a...f94992a. Read the comment docs.

Copy link
Member

@bxy4543 bxy4543 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@allencloud allencloud merged commit 76f9012 into sealerio:main Jun 16, 2022
@allencloud allencloud deleted the rm-rust branch June 16, 2022 01:09
bxy4543 pushed a commit to bxy4543/sealer that referenced this pull request Jun 27, 2022
Signed-off-by: Allen Sun <shlallen1990@gmail.com>
@allencloud allencloud restored the rm-rust branch July 9, 2022 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants