bugfix: add auth flag for cluster scale #1489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1489 +/- ##
==========================================
- Coverage 11.74% 11.67% -0.08%
==========================================
Files 76 76
Lines 6792 6833 +41
==========================================
Hits 798 798
- Misses 5892 5933 +41
Partials 102 102
Continue to review full report at Codecov.
|
allencloud
reviewed
Jun 9, 2022
| @@ -96,6 +96,7 @@ func init() { | |||
| deleteCmd.Flags().StringVarP(&deleteArgs.Nodes, "nodes", "n", "", "reduce Count or IPList to nodes") | |||
| deleteCmd.Flags().StringVarP(&deleteClusterFile, "Clusterfile", "f", "", "delete a kubernetes cluster with Clusterfile Annotations") | |||
| deleteCmd.Flags().StringVarP(&deleteClusterName, "cluster", "c", "", "delete a kubernetes cluster with cluster name") | |||
| deleteCmd.Flags().StringSliceVarP(&deleteArgs.CustomEnv, "env", "e", []string{}, "set custom environment variables") | |||
There was a problem hiding this comment.
its set , thats because in some case user want to set custom Env params for supporting execute clean scripts .
|
/test apply |
bxy4543
approved these changes
Jun 9, 2022
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Does this pull request fix one issue?
fixes #1469
Describe how you did it
Describe how to verify it
test success on my side:
all cluster node use the same password:
all cluster node use the different password:
Special notes for reviews