chore: replace cloud image with ClusterImage #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88ac320 to
685cd44
Compare
Signed-off-by: Allen Sun <shlallen1990@gmail.com>
685cd44 to
7973fdb
Compare
|
our official website documentation also needs to be updated to |
kakaZhou719
approved these changes
Jun 8, 2022
bxy4543
pushed a commit
to bxy4543/sealer
that referenced
this pull request
Jun 27, 2022
Signed-off-by: Allen Sun <shlallen1990@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Allen Sun shlallen1990@gmail.com
Describe what this PR does / why we need it
Like what mentioned in #1371 .
Currently in sealer's concept, CloudImage represents the Image which is built from Kubefile. CloudImage now is used to reveal a cluster with applications and Kubernetes inside.
While I am just wondering if Cloud in CloudImage is the suitable name for this situation. Cloud generally refers to a quite wide and abstract service all around the industry. Maybe CloudImage is much larger than what sealer wishes to mean.
Back to the theme, I think maybe ClusterImage is a little bit more accurate than CloudImage.
Just propose this topic to all the community and maintainer to take this into consideration.
In addition, in gravity https://github.com/gravitational/gravity, it refers to ClusterImage as well: https://github.com/gravitational/gravity#cluster-images
Does this pull request fix one issue?
fixes #1371
Describe how you did it
none
Describe how to verify it
none
Special notes for reviews
none