-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved logging #292
Improved logging #292
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hooray! Love me some real logging. I did a little playing around with this and it's a nice improvement!
I just have some ideas to consolidate log construction and configuration to a single place, even if you want to have "separate" loggers for different modules... also making the ROS logger globally available...
6b16126
to
7889f4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is some high quality centralized logging
Better late than never!
I was digging through the
logging
module and made some nice updates. Now:print
(unless it's an actual print function) andwarnings.warn
calls have been replaced with actual loggingCloses #88