Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gracefully exit navigation action when target location is not specified #248

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

sea-bass
Copy link
Owner

Small bug fix when sending a ROS navigation action goal without the target_location set.

Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py00100% 
core
   __init__.py90100% 
   dynamics.py430100% 
   gazebo.py136894%55, 124, 230, 244–248
   hallway.py93891%193, 235–238, 262–264
   locations.py1312183%69, 71, 88, 103–104, 106, 117–118, 120–121, 138, 196, 211, 236, 246, 291, 302–303, 305–306, 335
   objects.py69494%78, 106, 137, 197
   robot.py4516685%259–260, 272, 275, 279–280, 285–286, 328–329, 337, 397–400, 404–407, 447, 449, 491–492, 494–495, 512–514, 530–532, 599–601, 626–628, 679–681, 750–752, 762, 806–808, 818, 833, 839, 842, 844, 846, 849–851, 861, 869, 875, 881, 887, 899, 941, 959, 962, 967
   room.py48197%113
   world.py73919074%147–148, 184–185, 189, 242–243, 245–246, 274–275, 298–300, 337–339, 351–353, 382–384, 409–411, 464, 478–479, 481–482, 497–499, 519–523, 525–527, 529–530, 533, 535–538, 542–546, 549–551, 554–565, 581–582, 600–602, 616–618, 654–656, 668–670, 692–694, 719–721, 769–770, 773, 789, 819–820, 831, 834, 842, 858–862, 864–866, 869–870, 873–876, 878, 881, 883–885, 887–889, 891, 906, 913, 924–928, 963–964, 968–969, 987–988, 994–995, 997–998, 1000, 1002–1003, 1005, 1007–1008, 1018–1019, 1022, 1024, 1038, 1040, 1047, 1094, 1125–1126, 1137, 1148–1150, 1152–1155, 1157, 1174–1175, 1179–1180, 1215–1216, 1218, 1235–1236, 1267, 1281–1284, 1296–1299, 1313, 1324–1325, 1327, 1371–1372, 1424, 1504–1505
   yaml_utils.py108694%65, 69, 171–172, 191–192
gui
   __init__.py20100% 
   main.py1983482%22–24, 45, 77–78, 203, 215–221, 228–231, 233, 236–242, 246, 251–252, 256–257, 268, 319–320
   world_canvas.py3016279%45–46, 48–52, 55, 61–62, 169–172, 176–177, 182–183, 190, 192, 249–251, 257, 274–276, 323, 380–381, 408–409, 411, 413–415, 418–421, 423, 427–433, 436, 439–440, 455–457, 460, 479, 522, 543, 547, 570, 587, 601
manipulation
   __init__.py10100% 
   grasping.py2366174%102, 110–112, 114–122, 124, 132, 462, 464–466, 470–472, 566–568, 571–575, 583, 586–588, 593–594, 600–604, 607–614, 617–619, 628, 630, 632–638
navigation
   __init__.py11190%37
   a_star.py771185%83–88, 90–92, 180, 189
   execution.py90792%73–75, 80–82, 119
   occupancy_grid.py1391489%44–47, 49–53, 56, 192, 226, 234, 238
   prm.py56492%60–61, 140, 149
   rrt.py1620100% 
   visualization.py32681%88–93
   world_graph.py58493%117, 120, 130, 139
planning
   __init__.py00100% 
   actions.py1120100% 
planning/pddlstream
   __init__.py7185%13
   default_mappings.py90100% 
   planner.py40880%119–126
   primitives.py61493%68, 82, 94, 232
   utils.py99891%66, 93, 105, 115–116, 207–208, 211
utils
   __init__.py00100% 
   general.py33487%23, 45, 51–52
   knowledge.py1542285%86, 117, 156–161, 163–164, 167–168, 170–173, 189, 204, 208, 250, 266, 329
   motion.py70395%93–94, 96
   polygon.py1110100% 
   pose.py890100% 
   search_graph.py93396%240–242
   trajectory.py67297%130, 165
TOTAL413556386% 

Tests Skipped Failures Errors Time
194 0 💤 0 ❌ 0 🔥 3m 19s ⏱️

@sea-bass sea-bass merged commit 50031fa into main Aug 23, 2024
7 checks passed
@sea-bass sea-bass deleted the fix-no-target-location branch August 23, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant