Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set init for compose services #157

Merged
merged 1 commit into from
Feb 6, 2024

Conversation

eholum
Copy link
Collaborator

@eholum eholum commented Feb 6, 2024

It's a minor change, but otherwise you have to wait ~10s for your containers to shutdown when you kill them (or smash ctrl-c).

@moriarty
Copy link

moriarty commented Feb 6, 2024

@eholum could you investigate and fix the failing tests / python-test while you're at it? 😆

@sea-bass
Copy link
Owner

sea-bass commented Feb 6, 2024

@eholum could you investigate and fix the failing tests / python-test while you're at it? 😆

LOL

Please ignore the test failure, somehow the coverage bot integration fails when the PR comes from a fork... which is sad.

If you want to write some conditions in the YAML that can detect this and skip that step... I won't be mad.

@eholum
Copy link
Collaborator Author

eholum commented Feb 6, 2024

If you want to write some conditions in the YAML that can detect this and skip that step...

One custom CI target coming up.

@sea-bass sea-bass merged commit af002cd into sea-bass:main Feb 6, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants