-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow canceling actions from the GUI #215
Comments
I am thinking the cancel button could be on the bottom right corner of the world, opposite to the "show collision polygons" checkbox. We can print a short message for the actions letting the user know something is in progress along with the cancel button. What do you think? |
Was thinking something like that, especially since I think after one of the new PRs there may also be a need for a "reset path planner" button as well |
Maybe an |
Undo would require some significant backend changes (and I at least don't see a use case for it right now). Canceling a currently executing path and resetting path planners are already implemented. |
Alright. I will work on this issue. Should I also look into reset path planner or will there be a separate issue for that? I was looking at the commit you made in #214. Is this the API to be called upon cancel? pyrobosim/pyrobosim/pyrobosim/core/robot.py Line 903 in c723f07
|
Yep, that's the one! And let's save the reset path planner til later since that PR is still waiting for review |
Since #214 was merged in, we now have all the backend APIs to do this, either for single actions that were kicked off by pushing GUI buttons, or because something in the backend sent an action or task plan to the robot(s).
The "hard" part is just figuring out where in the GUI to put this cancel button.
The
test/system/test_system.py
file should probably also have a test for clicking this cancel button.The text was updated successfully, but these errors were encountered: