CSS Fixes #64
Merged
CSS Fixes #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tyling" This reverts commit d8f206f. The commit was introduced to work-around some styling choices made by MarkBind, namely: * The #app div having the container-fluid class applied to it, which added a 15px padding on the horizontal sides of the page. * The footer having negative horizontal margins, which led to the footer extending past the boundary of the page. These styling choices have since been removed in MarkBind[1]: * The #app div does not have the container-fluid class applied to it any more. * The footer now has a margin of 0. As such, the changes made by d8f206f are not needed any more, so let's revert it. [1]: MarkBind/markbind@c20e941
In the official SE-EDU design, the site navbar at the top should stretch
across the entire page.
However, for the Learning Resources site, this does not happen. The site
navbar is constrained to a maximum width of 1000px and is centered in
the page. This makes the design of the Learning Resources site
inconsistent with the rest of the SE-EDU sites.
This is because a recent change in MarkBind[1] wraps the entire page
(minus the footer) in a #content-wrapper div, and the #content-wrapper
div is styled as:
#content-wrapper {
margin: 0 auto;
max-width: 1000px;
overflow-x: hidden;
padding: 0 20px;
width: 100%;
}
thus leading to the current behavior.
Fix this by overriding #content-wrapper's `max-width` and `padding`
properties, so that the site navbar will stretch acorss the entire page.
[1]: MarkBind/markbind@c20e941
damithc
approved these changes
Sep 17, 2018
|
@damithc Ready for merge, btw :-) |
|
Oops. Sorry, missed it. Will merge over the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for the site CSS to deal with the changes made by MarkBind/markbind@c20e941