This repository has been archived by the owner on Mar 5, 2023. It is now read-only.
Model: Add deleteTag(Tag) #591
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@yamgent, thanks for your PR! By analyzing the history of the files in this pull request, we identified @damithc, @Zhiyuan-Amos and @yl-coder to be potential reviewers. |
nbriannl
reviewed
Oct 6, 2017
| ReadOnlyPerson oldPerson = addressBook.getPersonList().get(i); | ||
|
|
||
| Person newPerson = new Person(oldPerson); | ||
| Set<Tag> newTags = newPerson.getTags(); |
There was a problem hiding this comment.
getTags() returns an immutable tag set, which throws UnsupportedOperationException if modification is attempted.
making the subsequent newTags.remove(tag) method wrong.
There was a problem hiding this comment.
Set<Tag> newTags = new HashSet<Tag>(newPerson.getTags()); would work in place of Line 91
nbriannl
reviewed
Oct 9, 2017
|
|
||
| Person newPerson = new Person(oldPerson); | ||
| Set<Tag> newTags = newPerson.getTags(); | ||
| newTags.remove(tag); |
There was a problem hiding this comment.
For reference, .remove(tag) on immutable newTags will throw Exception.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is for the developer guide, we are not merging this.