Create MultiTableMetadata class
#924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## V1.0.0.dev #924 +/- ##
==============================================
+ Coverage 70.26% 73.34% +3.08%
==============================================
Files 39 40 +1
Lines 3027 3377 +350
==============================================
+ Hits 2127 2477 +350
Misses 900 900
Continue to review full report at Codecov.
|
fealho
reviewed
Jul 26, 2022
| - Instance of ``MultiTableMetadata``. | ||
| - Add mocked values to ``instance._tables`` and ``instance._relationships``. | ||
| Mock: | ||
| - Mock ``SingleTableMetadata`` like object to ``instance._tables``. |
There was a problem hiding this comment.
There are a lot of SingleTableMetadata in the multitable files. Maybe ctrl f for them and put MultiTableMetadata instead.
There was a problem hiding this comment.
I think they should be ok since they are mocks of SingleTableMetadata or just calls from it
fealho
reviewed
Jul 26, 2022
fealho
reviewed
Jul 26, 2022
amontanez24
approved these changes
Jul 26, 2022
There was a problem hiding this comment.
Besides @fealho 's comments this looks good to me. After addressing 
fealho
approved these changes
Jul 26, 2022
fealho
pushed a commit
that referenced
this pull request
Jul 29, 2022
pvk-developer
added a commit
that referenced
this pull request
Aug 9, 2022
pvk-developer
added a commit
that referenced
this pull request
Aug 10, 2022
amontanez24
pushed a commit
that referenced
this pull request
Sep 13, 2022
amontanez24
pushed a commit
that referenced
this pull request
Nov 22, 2022
amontanez24
pushed a commit
that referenced
this pull request
Dec 21, 2022
amontanez24
pushed a commit
that referenced
this pull request
Feb 17, 2023
amontanez24
pushed a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #883