Add load_from_json and save_to_json to SingleTableMetadata
#908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## V1.0.0.dev #908 +/- ##
==============================================
+ Coverage 69.18% 69.48% +0.29%
==============================================
Files 39 39
Lines 2921 2949 +28
==============================================
+ Hits 2021 2049 +28
Misses 900 900
Continue to review full report at Codecov.
|
amontanez24
requested changes
Jul 18, 2022
| 'class and version.' | ||
| ) | ||
|
|
||
| return cls._load_from_dict(metadata) |
There was a problem hiding this comment.
The constraint base class has to_dict and from_dict methods that I think we should use here. When someone loads from a json, we should load the constraint instances using that class method, and when they save to a json we should use the constraint's to_dict
amontanez24
approved these changes
Jul 19, 2022
67e9a2b to
6362a86
Compare
pvk-developer
added a commit
that referenced
this pull request
Jul 25, 2022
pvk-developer
added a commit
that referenced
this pull request
Aug 9, 2022
pvk-developer
added a commit
that referenced
this pull request
Aug 10, 2022
amontanez24
pushed a commit
that referenced
this pull request
Sep 13, 2022
amontanez24
pushed a commit
that referenced
this pull request
Nov 22, 2022
amontanez24
pushed a commit
that referenced
this pull request
Dec 21, 2022
amontanez24
pushed a commit
that referenced
this pull request
Feb 17, 2023
amontanez24
pushed a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #874