Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update preset param name #752

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Update preset param name #752

merged 1 commit into from
Mar 31, 2022

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Mar 30, 2022

Resolves #749

@katxiao katxiao requested a review from a team as a code owner March 30, 2022 15:47
@katxiao katxiao requested review from fealho and pvk-developer and removed request for a team March 30, 2022 15:47
pvk-developer
pvk-developer approved these changes Mar 31, 2022
View reviewed changes
Copy link
Member

@pvk-developer pvk-developer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@katxiao katxiao merged commit ccd323b into master Mar 31, 2022
@katxiao katxiao deleted the issue-749-update-preset-param branch March 31, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvk-developer pvk-developer pvk-developer approved these changes

@fealho fealho Awaiting requested review from fealho fealho was automatically assigned from sdv-dev/core-contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Change preset optimize_for --> name
2 participants
@katxiao @pvk-developer