Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display all attempted metrics #652

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Display all attempted metrics #652

merged 2 commits into from
Dec 10, 2021

Conversation

katxiao
Copy link
Contributor

@katxiao katxiao commented Dec 1, 2021

Resolves #638

@katxiao katxiao requested a review from csala December 1, 2021 17:08
@katxiao katxiao force-pushed the issue-638-metric-error-handling branch 2 times, most recently from 3bab465 to 13d2c23 Compare December 1, 2021 17:26
@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2021 •
edited
Loading

Codecov Report

Merging #652 (1245d4f) into master (3af5fe7) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #652      +/-   ##
==========================================
+ Coverage   64.92%   64.94%   +0.02%     
==========================================
  Files          34       34              
  Lines        2583     2582       -1     
==========================================
  Hits         1677     1677              
+ Misses        906      905       -1
Impacted Files Coverage Δ
sdv/evaluation.py 10.90% <ø> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3af5fe7...1245d4f. Read the comment docs.

@katxiao katxiao force-pushed the issue-638-metric-error-handling branch 2 times, most recently from 9b49b14 to 83b7240 Compare December 3, 2021 17:37
@katxiao katxiao changed the title Add option to display errored metrics Display all attempted metrics Dec 3, 2021
@katxiao katxiao marked this pull request as ready for review December 3, 2021 17:38
@katxiao katxiao requested a review from a team as a code owner December 3, 2021 17:38
@katxiao katxiao force-pushed the issue-638-metric-error-handling branch from 83b7240 to 845af7c Compare December 3, 2021 20:41
@katxiao katxiao force-pushed the issue-638-metric-error-handling branch from 845af7c to 190e635 Compare December 9, 2021 00:55
@katxiao katxiao force-pushed the issue-638-metric-error-handling branch from bad6522 to 1245d4f Compare December 9, 2021 23:06
@katxiao katxiao merged commit 9032c44 into master Dec 10, 2021
@katxiao katxiao deleted the issue-638-metric-error-handling branch December 10, 2021 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csala csala csala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Metric evaluation error handling
3 participants
@katxiao @codecov-commenter @csala