-
Notifications
You must be signed in to change notification settings - Fork 325
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3.13 #2367
Support Python 3.13 #2367
Conversation
Task linked: CU-86b2mqdjc SDV - Support Python 3.13 #2270 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2367 +/- ##
=======================================
Coverage 98.58% 98.58%
=======================================
Files 59 59
Lines 6144 6144
=======================================
Hits 6057 6057
Misses 87 87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
a471478
to
2ba7ee7
Compare
pyproject.toml
Outdated
'rdt>=1.13.2', | ||
'sdmetrics>=0.17.0', | ||
'copulas>=0.12.1', | ||
'ctgan @ git+https://github.com/sdv-dev/CTGAN@main', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you point this to the release candidate to test it? https://pypi.org/project/ctgan/0.11.0.dev0/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amontanez24 done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rwedge The actual release is out now!
3d060de
to
c553ca3
Compare
try: | ||
df = data[python_version] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the previous result did not include data for a particular python version it would error out
Resolves #2270
CU-86b2mqdjc