Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Python 3.13 #2367

Merged
merged 9 commits into from
Feb 27, 2025
Merged

Support Python 3.13 #2367

merged 9 commits into from
Feb 27, 2025

Conversation

rwedge
Copy link
Contributor

@rwedge rwedge commented Feb 11, 2025

Resolves #2270

CU-86b2mqdjc

@rwedge rwedge requested a review from a team as a code owner February 11, 2025 21:22
@rwedge rwedge requested review from amontanez24 and removed request for a team February 11, 2025 21:22
@sdv-team
Copy link
Contributor

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.58%. Comparing base (0b4d27e) to head (be641ba).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2367   +/-   ##
=======================================
  Coverage   98.58%   98.58%           
=======================================
  Files          59       59           
  Lines        6144     6144           
=======================================
  Hits         6057     6057           
  Misses         87       87           
Flag Coverage Δ
integration 82.21% <ø> (ø)
unit 97.44% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rwedge rwedge force-pushed the issue-2270-python-313 branch from a471478 to 2ba7ee7 Compare February 12, 2025 20:43
pyproject.toml Outdated
'rdt>=1.13.2',
'sdmetrics>=0.17.0',
'copulas>=0.12.1',
'ctgan @ git+https://github.com/sdv-dev/CTGAN@main',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you point this to the release candidate to test it? https://pypi.org/project/ctgan/0.11.0.dev0/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rwedge The actual release is out now!

@rwedge rwedge force-pushed the issue-2270-python-313 branch from 3d060de to c553ca3 Compare February 26, 2025 20:00
@rwedge rwedge requested review from amontanez24 and fealho February 27, 2025 16:34
try:
df = data[python_version]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the previous result did not include data for a particular python version it would error out

@rwedge rwedge merged commit ad28ad5 into main Feb 27, 2025
45 checks passed
@rwedge rwedge deleted the issue-2270-python-313 branch February 27, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.13
4 participants