Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip checking for Faker function if its a default sdtype #1410

Merged
merged 1 commit into from
May 8, 2023

Conversation

pvk-developer
Copy link
Member

As part of #1407

@pvk-developer pvk-developer changed the title Skip checking for faker if is a default sdtype Skip checking for Faker function if its a default sdtype May 5, 2023
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 96.20% and project coverage change: -0.05 ⚠️

Comparison is base (898850a) 96.54% compared to head (4f2e695) 96.49%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1410      +/-   ##
==========================================
- Coverage   96.54%   96.49%   -0.05%     
==========================================
  Files          48       48              
  Lines        3730     3770      +40     
==========================================
+ Hits         3601     3638      +37     
- Misses        129      132       +3     
Impacted Files Coverage Δ
sdv/constraints/tabular.py 98.89% <83.33%> (-0.36%) ⬇️
sdv/multi_table/base.py 98.45% <83.33%> (-0.50%) ⬇️
sdv/constraints/utils.py 100.00% <100.00%> (ø)
sdv/metadata/anonymization.py 100.00% <100.00%> (ø)
sdv/metadata/single_table.py 98.84% <100.00%> (+<0.01%) ⬆️
sdv/multi_table/hma.py 81.85% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pvk-developer pvk-developer marked this pull request as ready for review May 8, 2023 09:09
@pvk-developer pvk-developer requested a review from a team as a code owner May 8, 2023 09:09
@pvk-developer pvk-developer requested review from amontanez24 and removed request for a team May 8, 2023 09:09
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pvk-developer pvk-developer merged commit 80d0408 into master May 8, 2023
@pvk-developer pvk-developer deleted the improve-metadata-sdtype-validation branch May 8, 2023 20:22
@amontanez24 amontanez24 added this to the 1.1.0 milestone May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants