Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix order in which transformers are returned #1239

Merged
merged 1 commit into from
Feb 8, 2023
Merged

Fix order in which transformers are returned #1239

merged 1 commit into from
Feb 8, 2023

Conversation

pvk-developer
Copy link
Member

Resolves #1222

@pvk-developer pvk-developer marked this pull request as ready for review February 7, 2023 17:56
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2023 •
edited
Loading

Codecov Report

Base: 95.71% // Head: 95.71% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bf9a4aa) compared to base (9560adf).
Patch coverage: 100.00% of modified lines in pull request are covered.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files 
@@             Coverage Diff             @@
##           V1.0.0.dev    #1239   +/-   ##
===========================================
  Coverage       95.71%   95.71%           
===========================================
  Files              47       47           
  Lines            3641     3642    +1     
===========================================
+ Hits             3485     3486    +1     
  Misses            156      156
Impacted Files Coverage Δ
sdv/single_table/base.py 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pvk-developer pvk-developer requested a review from a team as a code owner February 7, 2023 17:56
@pvk-developer pvk-developer requested review from amontanez24 and fealho and removed request for a team February 7, 2023 17:56
amontanez24
amontanez24 approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@amontanez24 amontanez24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pvk-developer pvk-developer merged commit f709570 into V1.0.0.dev Feb 8, 2023
@pvk-developer pvk-developer deleted the issue-1222-order-output-of-get-output-transformers-based-on-metadata branch February 8, 2023 01:55
amontanez24 pushed a commit that referenced this pull request Feb 17, 2023
@pvk-developer @amontanez24
Fix order in which transformers are returned (#1239)
d7c9d06
amontanez24 pushed a commit that referenced this pull request Mar 23, 2023
@pvk-developer @amontanez24
Fix order in which transformers are returned (#1239)
ffca169
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amontanez24 amontanez24 amontanez24 approved these changes

@fealho fealho fealho approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pvk-developer @codecov-commenter @amontanez24 @fealho