Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 111 review unittests #113

Merged
merged 8 commits into from
Sep 18, 2019
Merged

Issue 111 review unittests #113

merged 8 commits into from
Sep 18, 2019

Conversation

JDTheRipperPC
Copy link
Contributor

Resolves #111

Removed use of an external file in unittests.

Added a new tests/utils.py to handle with the DataNavigator creation.

@JDTheRipperPC JDTheRipperPC requested a review from csala September 9, 2019 11:57
@CLAassistant
Copy link

CLAassistant commented Sep 9, 2019

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Sep 13, 2019

Codecov Report

Merging #113 into master will increase coverage by 0.3%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #113     +/-   ##
=========================================
+ Coverage   72.75%   73.06%   +0.3%     
=========================================
  Files           8        8             
  Lines         646      646             
=========================================
+ Hits          470      472      +2     
+ Misses        176      174      -2
Impacted Files Coverage Δ
sdv/data_navigator.py 100% <0%> (+2.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 31cdaa1...2e18bf2. Read the comment docs.

@csala csala merged commit 96724b1 into master Sep 18, 2019
@csala csala deleted the issue_111_review_unittests branch September 18, 2019 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review unittests
4 participants