Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt evaluation to the different data types #128

Closed
csala opened this issue Nov 14, 2019 · 0 comments · Fixed by #133
Closed

Adapt evaluation to the different data types #128

csala opened this issue Nov 14, 2019 · 0 comments · Fixed by #133
Assignees
Labels
feature request Request for a new feature
Milestone

Comments

@csala
Copy link
Contributor

csala commented Nov 14, 2019

The current evaluate function does not distinguish between the different field types and, most importantly, includes the id fields in the evaluation.

Id fields are not modeled and can be very different between the sampled and the real data, which means that they can produce a huge and meaningless impact on the produced scores.

The evaluate function should be changed to expect a metadata argument as input and adapt the evaluation to the different data types.

@csala csala changed the title Skip id fields when evaluating Adapt evaluation to the different data types Nov 14, 2019
@csala csala added approved feature request Request for a new feature labels Nov 14, 2019
@csala csala added this to the 0.2.1 milestone Nov 14, 2019
@csala csala removed this from the 0.2.1 milestone Nov 25, 2019
@csala csala added this to the 0.2.2 milestone Dec 4, 2019
@csala csala closed this as completed in #133 Dec 9, 2019
JonathanDZiegler pushed a commit to JonathanDZiegler/SDV that referenced this issue Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants