-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: salted hashing #41
Conversation
Example use: ➜ tripsu pseudo -s secret.txt -c tests/data/config.yaml -x tests/data/type_map.nt tests/data/test.nt | tail -n3
<http://example.org/7c73d8167447e118ee76295f252e9ceeb48ae3cbfa0454572381796f0e7a8e2c> <http://schema.org/name> "f4446c44c9b6e221e94a40476322dab5123514c5669092a142057a3322329c09" .
<http://example.org/Bank> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://xmlns.com/foaf/0.1/Organization> .
<http://example.org/Bank> <http://schema.org/name> "Bank" .
➜ tripsu pseudo -c tests/data/config.yaml -x tests/data/type_map.nt tests/data/test.nt | tail -n3
<http://example.org/e72357361fec5fc2f653642e6a1016040aa79097ab123468f3f7873907211d26> <http://schema.org/name> "f4aab5970bf4589ea821964476f10ddcef7b2a42a4796954f5cb32426bc5ec55" .
<http://example.org/Bank> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://xmlns.com/foaf/0.1/Organization> .
<http://example.org/Bank> <http://schema.org/name> "Bank" . |
Took your points into account and added tests + docstrings! |
Just realized something: if we plan to support asymmetric encryption, wouldn't |
For this, I think we should just change the behavior of tripsu when asymmetric encryption is used and require It does not really make sense to me to support it for the following reasons:
tldr; I wouldn't worry about this for now 😁 |
Co-authored-by: martinfontanet <martinfontanet@users.noreply.github.com>
Proposed Changes
--secret
CLI arg to provide a file with encryption key or hashing salt.Pseudonymize
to a single method (pseudo(bytes) -> String
).Types of Changes
What types of changes does your code introduce? Put an
x
in the boxes thatapply
functionality to not work as expected).
other choices apply).
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creatingthe PR. If you're unsure about any of them, don't hesitate to ask. We're here to
help! This is simply a reminder of what we are going to look for before merging
your code.
CONTRIBUTING
guidelines.
works.
Further Comments