Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Custom Feature Spaces in Dialogue #712

Merged
merged 5 commits into from
Feb 21, 2025
Merged

Allow Custom Feature Spaces in Dialogue #712

merged 5 commits into from
Feb 21, 2025

Conversation

Zethson
Copy link
Member

@Zethson Zethson commented Feb 21, 2025

Originally contributed by @grpinto.

Fixes #668 where users requested greater flexibility in specifying the feature space for the Dialogue implementation. Previously, the Dialogue function was limited to using PCA via the _pseudobulk_pca method, which prevented users from easily experimenting with or formally documenting the use of alternative feature reduction techniques.

Changes Introduced:

Refactored Feature Extraction:
The internal function call has been updated from _pseudobulk_pca to _pseudobulk_feature_space. Small adjustment to make the label flexible to the user.

Existing functionality has been preserved. For users who rely on the default PCA behavior, the changes maintain backward compatibility while offering an easy path to extend or replace the feature space as needed.
Testing & Verification:

Confirmed that the Dialogue function correctly applies the specified feature space.
Ran all existing tests to ensure no regressions in other parts of the codebase.

@Zethson Zethson marked this pull request as ready for review February 21, 2025 08:50
@Zethson Zethson merged commit 28bc4e3 into main Feb 21, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dialogue feature space
1 participant