-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add perturbation signature calculation from replicate control cells #695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pertpy/tools/_mixscape.py # tests/tools/test_mixscape.py
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #695 +/- ##
==========================================
+ Coverage 64.89% 64.92% +0.02%
==========================================
Files 46 46
Lines 5994 6004 +10
==========================================
+ Hits 3890 3898 +8
- Misses 2104 2106 +2
|
# Conflicts: # pertpy/tools/_mixscape.py # tests/tools/test_mixscape.py
Zethson
approved these changes
Feb 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank youuuu!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
docs
is updatedDescription of changes
As discussed, we would like to have an alternative to the standard Mixscape perturbation signature calculation. Instead of using the X nearest control cells as a reference, this approach considers all control cells within the same replicate. This change (and the corresponding test) is introduced in this PR. Specifically, I added the parameter
ref_selection_mode
to theperturbation_signature
method, allowing users to select which mode to use:nn
for the standard approach ormanual
for selection via the specified replicate method (I’m open to suggestions for better names!).I also added the preprint citation to the docs, since I noticed that was missing.