Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: rolling hash implementation #42

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Fix: rolling hash implementation #42

merged 4 commits into from
Feb 14, 2025

Conversation

roynalnaruto
Copy link
Contributor

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

The rolling hash computation clears 32-bits instead of 36-bits. Reference.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Feb 13, 2025

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@roynalnaruto roynalnaruto mentioned this pull request Feb 14, 2025
Merged
@jonastheis jonastheis merged commit 8fa5e27 into feat/codec-v6 Feb 14, 2025
4 checks passed
@jonastheis jonastheis deleted the fix/rolling-hash-impl branch February 14, 2025 09:28
Thegaram added a commit that referenced this pull request Feb 21, 2025
@jonastheis @omerfirmak
@Thegaram @roynalnaruto @colinlyguo
feat(CodecV7): add CodecV7 to support upgrade 5.2 Euclid phase2 (#33)
2ace506 
* add initial CodecV6 and daBatchV6

* feat: add codecv5  and codecv6 for Euclid fork

* implement blob encoding and decoding according to new blob layout

* rename to CodecV7

* add NewDABatchFromParams

* add DecodeBlob to Codec

* Update da.go

* Update interfaces.go

* fixes after merge

* address review comments

* add sanity checks for blob payload generation

* fix few small bugs uncovered by unit tests

* upgrade to latest l2geth version and add correct getter for CodecV7 in CodecFromConfig

* fix linter warnings

* add unit tests

* go mod tidy

* fix linter warnings

* add function MessageQueueV2ApplyL1MessagesFromBlocks to compute the L1 message hash from a given set of blocks

* fix lint and unit test errors

* call checkCompressedDataCompatibility only once -> constructBlobPayload only once

* address review comments

* update BlobEnvelopeV7 documentation

* add CodecV7 to general util functions

* add InitialL1MessageQueueHash and LastL1MessageQueueHash to encoding.Chunk

* go mod tidy

* upgrade go-ethereum dependency to latest develop

* implement estimate functions

* update TestMain and run go mod tidy

* add NewDAChunk to CodecV7 for easier use in relayer

* add daChunkV7 type to calculate chunk hash

* allow batch.chunks but check consistency with batch.blocks

* fix off-by-one error with L1 messages

* Fix: rolling hash implementation (#42)

* fix: clear 32 bits instead of 36

* fix: test expectations for rolling hash

* fix: tests

* fix tests

---------

Co-authored-by: jonastheis <4181434+jonastheis@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>

* rename initialL1MessageQueueHash -> prevL1MessageQueueHash and lastL1MessageQueueHash -> postL1MessageQueueHash

* address review comments

* address review comments

* add challenge digest computation for batch

* remove InitialL1MessageIndex from CodecV7

* address review comments

* fix tests

* refactoring to minimize duplicate code and increase maintainability

* fix nil pointer

* address review comments

---------

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@ip-192-168-0-18.us-west-2.compute.internal>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Co-authored-by: Rohit Narurkar <rohit.narurkar@proton.me>
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonastheis jonastheis jonastheis approved these changes

@Thegaram Thegaram Thegaram approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roynalnaruto @jonastheis @Thegaram